Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libpqxx] linux support #11442

Merged
merged 16 commits into from
May 21, 2020
Merged

[libpqxx] linux support #11442

merged 16 commits into from
May 21, 2020

Conversation

alexander-smyslov
Copy link
Contributor

Describe the pull request

  • What does your PR fix? Fixes #
    add linux support

  • Which triplets are supported/not supported?
    x64-linux
    Have you updated the CI baseline?

  • Does your PR follow the maintainer guide?

NancyLi1013
NancyLi1013 reviewed May 19, 2020
View reviewed changes
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also bump the version as 6.4.5-3 in CONTROL file?

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label May 20, 2020
strega-nil
strega-nil approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes, then we should get this merged :)

What's up with the baseline, though? Shouldn't it need to be changed? Was it just silently failing before?

ports/libpqxx/CMakeLists.txt Outdated Show resolved Hide resolved
ports/libpqxx/CMakeLists.txt Outdated Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

@strega-nil
I have checked baseline and it seems that there are no any triplets set for libpqxx before.
So we don't neede to update the baseline.

NancyLi1013
NancyLi1013 suggested changes May 21, 2020
View reviewed changes
ports/libpqxx/CMakeLists.txt Outdated Show resolved Hide resolved
@strega-nil @NancyLi1013
Update ports/libpqxx/CMakeLists.txt
5b28e93 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@strega-nil
Copy link
Contributor

Alright cool, thanks much @alexander-smyslov :)

@strega-nil strega-nil merged commit f075c6b into microsoft:master May 21, 2020
@alexander-smyslov alexander-smyslov deleted the libpqxx_linux_support branch May 21, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 requested changes

@strega-nil strega-nil strega-nil approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-smyslov @NancyLi1013 @strega-nil