Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[protobuf-c] Fix tool protoc-gen-c crash #11517

Merged
merged 1 commit into from
May 27, 2020
Merged

[protobuf-c] Fix tool protoc-gen-c crash #11517

merged 1 commit into from
May 27, 2020

Conversation

JackBoosY
Copy link
Contributor

Fix crash issue when using tool protoc-gen-c：

terminate called after throwing an instance of 'std::system_error'
  what():  Unknown error -1
--c_out: protoc-gen-c: Plugin killed by signal 6.

Fixes: #10745.

Thanks @lipnitsk !

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels May 22, 2020
@JackBoosY
Copy link
Contributor Author

@victech-yeoinbo Could you test this PR?

Thanks.

@victech-yeoinbo
Copy link

Yeah. I tested this PR and it worked well.
Thanks!

@PhoebeHui PhoebeHui marked this pull request as ready for review May 22, 2020 09:51
PhoebeHui
PhoebeHui approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 22, 2020
Neumann-A
Neumann-A reviewed May 22, 2020
View reviewed changes
ports/protobuf-c/fix-usage-issue.patch

TARGET_LINK_LIBRARIES(protoc-gen-c ${PROTOBUF_PROTOC_LIBRARY} ${PROTOBUF_LIBRARY})
+IF(CMAKE_HOST_UNIX)
+ TARGET_LINK_LIBRARIES(protoc-gen-c ${CMAKE_THREAD_LIBS_INIT})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not Threads::Threads?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neumann-A That use the upstream PR #425 changes.

@dan-shaw dan-shaw merged commit 6ca5fb6 into microsoft:master May 27, 2020
@JackBoosY JackBoosY deleted the dev/jack/10745 branch May 27, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

protobuf-c code generation using protoc-gen-c is not working
5 participants
@JackBoosY @victech-yeoinbo @PhoebeHui @Neumann-A @dan-shaw