Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trantor] Add new port #11533

Merged
merged 3 commits into from
Jun 2, 2020
Merged

[trantor] Add new port #11533

merged 3 commits into from
Jun 2, 2020

Conversation

an-tao
Copy link
Contributor

@an-tao an-tao commented May 23, 2020

Describe the pull request

  • What does your PR fix? Fixes #

This PR is adding the trantor library.

@msftclas
Copy link

msftclas commented May 23, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@an-tao an-tao marked this pull request as ready for review May 23, 2020 07:24
@an-tao an-tao mentioned this pull request May 24, 2020
Merged
@NancyLi1013 NancyLi1013 self-assigned this May 25, 2020
NancyLi1013
NancyLi1013 suggested changes May 25, 2020
View reviewed changes
ports/trantor/portfile.cmake Outdated Show resolved Hide resolved
ports/trantor/portfile.cmake Outdated Show resolved Hide resolved
ports/trantor/portfile.cmake Outdated Show resolved Hide resolved
ports/trantor/portfile.cmake Outdated Show resolved Hide resolved
ports/trantor/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels May 25, 2020
an-tao and others added 2 commits May 25, 2020 17:09
@an-tao @NancyLi1013
Apply suggestions from code review
9e8dd7d 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@an-tao
Remove unused lines.
b3ae32c
@an-tao
Copy link
Contributor Author

an-tao commented May 25, 2020 •
edited
Loading

@NancyLi1013 Thanks for your suggestions. Why it fails in CI after the modification?

@NancyLi1013
Copy link
Contributor

The regressions for apr and apr-util have been fixed in #11559.
This is not related with this PR. So you can ignore them. I'll rerun this PR once solved.

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 27, 2020
@dan-shaw dan-shaw merged commit 60e3690 into microsoft:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@an-tao @msftclas @NancyLi1013 @dan-shaw