[polyhook2] Update to 2020-05-25 #11561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update to latest PolyHook_2 revision. - Add support for zydis and inlinentd as features (enabled by default, as per upstream default). - Support for capstone, exception, detours, and pe is now configurable via features (all enabled by default, as per upstream default). - Remove cmake build patch. Relevant parts have been upstreamed. - For now, remove tool feature for building tests, as upstream does not support building tests along with building the library. - Add support for cmake config so library can be used simply with "find_package(PolyHook_2 CONFIG REQUIRE)".
|
Awesome! I am fine with these settings |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
suggested changes
May 26, 2020
NancyLi1013
added
category:port-update
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
|
Many thanks for the timely review. If anything else is needed, let me know. |
NancyLi1013
approved these changes
May 27, 2020
|
Need to test features manually. I will update the results once finished. Currently, there is no need to do anything. |
|
All features have passed with the following triplets:
|
NancyLi1013
added
info:reviewed
|
I'm glad everything passed review. Anything else needed? |
|
Nothing needs to be done, just waiting for the merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest PolyHook_2 revision.
Add support for zydis and inlinentd as features (enabled by default, as per upstream default).
Support for capstone, exception, detours, and pe is now configurable via features (all enabled by default, as per upstream default).
Remove cmake build patch. Relevant parts have been upstreamed.
For now, remove tool feature for building tests, as upstream does not support building tests along with building the library. (The original port carried a very large patch to the cmake build script to make this work, which is likely to keep breaking with upstream changes.)
Add support for cmake config so library can be used simply with "find_package(PolyHook_2 CONFIG REQUIRED)".
Describe the pull request
What does your PR fix? See above.
Which triplets are supported/not supported? Have you updated the CI baseline? All standard triplets tested and supported.
Does your PR follow the maintainer guide? Yes.
cc upstream @stevemk14ebr