Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pcre] Add pkgconfig files #11564

Merged

Conversation

c72578
Copy link
Contributor

@c72578 c72578 commented May 25, 2020

Describe the pull request
Add pkgconfig files to pcre

  • What does your PR fix? Fixes #
    So far, libpcre*.pc files are missing. This enables pcre to be found using pkgconfig

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    All current triplets are supported.

  • Does your PR follow the maintainer guide?
    Yes

@c72578 c72578 force-pushed the 2020-05-25_pcre_Add_pkgconfig_files branch from e346412 to 898e894 Compare May 25, 2020 15:55
@c72578 c72578 marked this pull request as ready for review May 25, 2020 18:52
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@c72578 c72578 force-pushed the 2020-05-25_pcre_Add_pkgconfig_files branch from 94bedf0 to 55ef63d Compare May 26, 2020 17:55
@c72578
Copy link
Contributor Author

c72578 commented May 28, 2020

@PhoebeHui the PR is ready for review.

@PhoebeHui
Copy link
Contributor

@c72578, thanks for the PR!

Could you pelase report an issue to pcre about this changes? if pcre handle that in their offical CMakelist.txt file, then we can remove it in portfile.cmake file in future.

@PhoebeHui PhoebeHui added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 29, 2020
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 29, 2020
@c72578
Copy link
Contributor Author

c72578 commented May 31, 2020

Could you pelase report an issue to pcre about this changes? if pcre handle that in their offical CMakelist.txt file, then we can remove it in portfile.cmake file in future.

An upstream issue including a proposed patch has been submitted upstream now:
https://bugs.exim.org/show_bug.cgi?id=2583

@dan-shaw dan-shaw merged commit b800df0 into microsoft:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants