Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[telnetpp] Add missing <ostream> for Visual Studio 2019 16.6 #11573

Merged
merged 3 commits into from
May 27, 2020
Merged

[telnetpp] Add missing <ostream> for Visual Studio 2019 16.6 #11573

merged 3 commits into from
May 27, 2020

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented May 25, 2020 •
edited
Loading

Previously submitted as KazDragon/telnetpp#215

@BillyONeal BillyONeal added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels May 25, 2020
PhoebeHui
PhoebeHui requested changes May 26, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comments for making the patch file smaller.

ports/telnetpp/github-215.patch Outdated Show resolved Hide resolved
ports/telnetpp/github-215.patch Outdated Show resolved Hide resolved
@BillyONeal
Copy link
Member Author

Remove the comments for making the patch file smaller.

I put the comments there to make it identical to the GitHub PR commit so that it's clear once we take a version with that commit integrated that the patch can be removed.

@BillyONeal
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member Author

@PhoebeHui Looks like you removed the bits you didn't like yourself but you're still marked as requesting changes. Is there anything else you're looking for?

Thanks!

PhoebeHui
PhoebeHui approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Billy!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 27, 2020
@BillyONeal BillyONeal merged commit 7e4ab79 into microsoft:master May 27, 2020
@BillyONeal BillyONeal deleted the update_telnetpp branch May 27, 2020 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillyONeal @PhoebeHui