Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[seal] Disable SEAL_USE_MSGSL and add default feature zlib #11588

Merged
merged 1 commit into from
May 27, 2020
Merged

[seal] Disable SEAL_USE_MSGSL and add default feature zlib #11588

merged 1 commit into from
May 27, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented May 26, 2020 •
edited
Loading

  1. Since seal will fail to compile (source bug) when using ms-gsl, disable this option SEAL_USE_MSGSL and re-enable it after future fixes.
  2. Add feature and set it as default feature (According to CMakeLists.txt in source).

Related: #159 #10918 #11502.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels May 26, 2020
@JackBoosY JackBoosY marked this pull request as ready for review May 26, 2020 08:47
@JackBoosY JackBoosY requested a review from PhoebeHui May 26, 2020 08:47
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 26, 2020
@dan-shaw dan-shaw merged commit 323cd68 into microsoft:master May 27, 2020
@JackBoosY JackBoosY deleted the dev/jack/disable_msgsl_in_seal branch May 27, 2020 05:43
@MonicaLiu0311 MonicaLiu0311 mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackBoosY @PhoebeHui @dan-shaw