Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpprestsdk] Avoid using pkg-config to find OpenSSL libraries on Linux #11694

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

orudge
Copy link
Contributor

@orudge orudge commented Jun 1, 2020

When linking to a vcpkg-built C++ REST SDK on Linux, I noticed my executables being generated had redundant references to libssl.so.1.1 and libcrypto.so.1.1, rather than the static libraries built by vcpkg being used.

I tracked the issue down to an issue in the C++ REST SDK cpprest_find_openssl.cmake file. I have submitted a pull request to the project directly (microsoft/cpprestsdk#1438) but this should fix the issue in the mean time.

@Neumann-A
Copy link
Contributor

Neumann-A commented Jun 1, 2020

Correct fix would be to call cmake with CMAKE_DISABLE_FIND_PACKAGE_PkgConfig=ON instead... there is no need to fix it upstream ....

Or if that does not work due to possible macro errors try:
-DPKG_CONFIG_EXECUTABLE=FALSE

@orudge orudge force-pushed the cpprestsdk-fix-openssl-detection branch from 2c118c4 to 30fcbc3 Compare June 1, 2020 14:29
@orudge
Copy link
Contributor Author

orudge commented Jun 1, 2020

Or if that does not work due to possible macro errors try:
-DPKG_CONFIG_EXECUTABLE=FALSE

Thanks for the hint, that looks to work better.

@LilyWangL LilyWangL added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines labels Jun 2, 2020
@dan-shaw dan-shaw merged commit 23efb17 into microsoft:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants