Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enet] Update to 1.3.15 #11702

Merged
merged 6 commits into from
Jun 3, 2020
Merged

[enet] Update to 1.3.15 #11702

merged 6 commits into from
Jun 3, 2020

Conversation

Fohlen
Copy link
Contributor

@Fohlen Fohlen commented Jun 1, 2020

Describe the pull request

@msftclas
Copy link

msftclas commented Jun 1, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@NancyLi1013 NancyLi1013 self-assigned this Jun 2, 2020
@NancyLi1013 NancyLi1013 changed the title Update enet [enet] Update to 1.3.15 Jun 2, 2020
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 2, 2020
NancyLi1013
NancyLi1013 suggested changes Jun 2, 2020
View reviewed changes
ports/enet/CONTROL Outdated Show resolved Hide resolved
ports/enet/portfile.cmake Outdated Show resolved Hide resolved
@Fohlen Fohlen mentioned this pull request Jun 2, 2020
Merged
12 tasks
@Fohlen
Copy link
Contributor Author

Fohlen commented Jun 2, 2020

Hey @NancyLi1013
The tests seem to fail for obtrusive reasons. How would we go about fixing and merging this?

@NancyLi1013
Copy link
Contributor

The failure has been resolved now.
LGTM, thanks for this PR @Fohlen .

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jun 3, 2020
@dan-shaw dan-shaw merged commit 37ab610 into microsoft:master Jun 3, 2020
@Fohlen Fohlen deleted the update-enet branch June 3, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enet update to 1.3.15
4 participants
@Fohlen @msftclas @NancyLi1013 @dan-shaw