Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ace] Fix missing cpp files #11713

Merged
merged 31 commits into from
Jun 3, 2020
Merged

[ace] Fix missing cpp files #11713

merged 31 commits into from
Jun 3, 2020

Conversation

jwillemsen
Copy link
Contributor

Install all cpp files, we have a lot of source files with inline methods. At some point we should try to use the MPC prj_install support as alternative

@jwillemsen
[ace] Update to 6.5.8
974ae7b
@jwillemsen
Address review comments
0f88c1a 
    * ports/ace/portfile.cmake:
@jwillemsen
Put back copy step
411981f 
    * ports/ace/portfile.cmake:
@jwillemsen
Fixed error
0c31b88 
    * ports/ace/portfile.cmake:
@jwillemsen
ARM should work, let us try it
aeec218 
    * ports/ace/portfile.cmake:
@jwillemsen
ARM doesn't work yet, so disable it again
d3d5f66 
    * ports/ace/portfile.cmake:
@jwillemsen
Merge branch 'master' of https://github.com/Microsoft/vcpkg
6b22b90
@jwillemsen
Merge branch 'master' of https://github.com/Microsoft/vcpkg
4bc796b
@jwillemsen
Add support for vcpkg of ace on MacOSX
1162f9a 
    * ports/ace/portfile.cmake:
@jwillemsen
Merge branch 'master' of https://github.com/Microsoft/vcpkg
42ed50c
@jwillemsen
Merge branch 'master' of https://github.com/Microsoft/vcpkg
751fb81
@jwillemsen
Merge branch 'master' of https://github.com/Microsoft/vcpkg
0b96ccf
@jwillemsen
Merge branch 'master' of https://github.com/Microsoft/vcpkg
158f002
@jwillemsen
Merge branch 'master' of https://github.com/Microsoft/vcpkg
77ab4e6
@jwillemsen
[ace] Add patch to fix Visual Studio 2019 internal compiler error
642a4e1 
    * ports/ace/process_manager.patch:
      Added.

    * ports/ace/CONTROL:
    * ports/ace/portfile.cmake:
@jwillemsen
Attempt to fix apply patches
0bcf649 
    * ports/ace/portfile.cmake:
@jwillemsen
[ace] Updated baseline for ace, 4 configurations work again with the …
73985a0 
…applied patch

    * scripts/ci.baseline.txt:
@jwillemsen
Address review comments
5f8ad22 
    * ports/ace/portfile.cmake:
@jwillemsen
Revised patch for ACE
0ea23d3 
    * ports/ace/process_manager.patch:
@jwillemsen
Merge branch 'master' of https://github.com/Microsoft/vcpkg
a22f3e1
@jwillemsen
Merge branch 'master' into jwi-ace-659patch
506ebd5
@jwillemsen
[ace] Add support for uwp
e870128 
    * ports/ace/portfile.cmake:
@jwillemsen
Merge branch 'jwi-ace-659patch'
b264978
@jwillemsen
ace now works in all configurations
77d7c93 
    * scripts/ci.baseline.txt:
@jwillemsen
Removed !uwp and update version
d583340 
    * ports/ace/CONTROL:
@jwillemsen
Simplified install of copyright file and on windows we always have a …
6f46b29 
…QoS library

    * ports/ace/portfile.cmake:
@jwillemsen
[ace] resolve merge conflicts
9712200
@jwillemsen
Merge branch 'master' of https://github.com/Microsoft/vcpkg
ad64f9f
@jwillemsen
Merge branch 'master' of https://github.com/Microsoft/vcpkg
c406a36
@jwillemsen
Install all cpp files, at some point we should try the MPC install su…
1ef8dd1 
…pport on Windows
@JackBoosY JackBoosY self-assigned this Jun 2, 2020
JackBoosY
JackBoosY suggested changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version info. See documentation.

@jwillemsen jwillemsen requested a review from JackBoosY June 2, 2020 06:08
@JackBoosY
Copy link
Contributor

JackBoosY commented Jun 2, 2020 •
edited
Loading

The osg regression is fixing in #11715.

@jwillemsen jwillemsen changed the title Fix missing ACE cpp files [ace] Fix missing cpp files Jun 2, 2020
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Jun 3, 2020
@dan-shaw dan-shaw merged commit 77f46d4 into microsoft:master Jun 3, 2020
@jwillemsen jwillemsen deleted the jwi-ace-installcpp branch June 3, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ace: Missing installed header ace/Intrusive_List.cpp
4 participants
@jwillemsen @JackBoosY @BillyONeal @dan-shaw