[p-ranav-csv2] Add new port #11725
Merged
[p-ranav-csv2] Add new port #11725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JackBoosY
approved these changes
Jun 3, 2020
|
@SuperWig Does this PR ready for review? |
JackBoosY
added
the
category:new-port
|
@JackBoosY Yup |
JackBoosY
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Adds csv2 header only library https://github.com/p-ranav/csv2
Also marks their previous p-ranav-csv port as deprecated
Which triplets are supported/not supported? Have you updated the CI baseline?
Pretty sure everything should be supported.
Does your PR follow the maintainer guide?
Yes
The port could probably be called just "csv2" but still seems too generic.