[librabbitmq] Update to use rabbitmq-config.cmake #11733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NancyLi1013
suggested changes
Jun 3, 2020
NancyLi1013
added
category:port-update
NancyLi1013
changed the title
|
@NancyLi1013 Thank you for your feedback! I've made the proposed changes. |
trollham
force-pushed
the
update_rabbitmq_port
branch
from
5db9ad1
to
f56f6b4
Compare
NancyLi1013
approved these changes
Jun 4, 2020
trollham
force-pushed
the
update_rabbitmq_port
branch
from
f56f6b4
to
b954e6c
Compare
trollham
force-pushed
the
update_rabbitmq_port
branch
from
b954e6c
to
2435d74
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks for the PR! |
JangBoo
pushed a commit
to JangBoo/vcpkg
that referenced
this pull request
Jun 18, 2020
* Update librabbitmq portfile to use rabbitmq-config.cmake * Change version and update outdated vcpkg functions * Capitalization error Co-authored-by: Eric Huff <thegreaterici@gmail.com>
penumbra23
pushed a commit
to codespace-dev/vcpkg
that referenced
this pull request
Aug 5, 2020
* Update librabbitmq portfile to use rabbitmq-config.cmake * Change version and update outdated vcpkg functions * Capitalization error Co-authored-by: Eric Huff <thegreaterici@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rabbitmq-c library recently merged a pull request that implemented config-file generation. Vcpkg can now better integrate librabbitmq into it's ecosystem. I tested this works on the following triplets: x64-linux, x64-windows, and a custom x64-windows-static which just changes library linkage from "dynamic" to "static".