Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg README] Add #include<C++> channel #11750

Merged
merged 2 commits into from
Jun 5, 2020
Merged

[vcpkg README] Add #include<C++> channel #11750

merged 2 commits into from
Jun 5, 2020

Conversation

strega-nil
Copy link
Contributor

We have a channel on #include <C++>, so add it to the readme.

@Hoikas
Copy link
Contributor

Hoikas commented Jun 3, 2020 •
edited
Loading

The SSL certificate for the domain is configured for only https://www.includecpp.org and not https://includecpp.org, so this link leads to a "Security Error" in most browsers.

@strega-nil
Fix includecpp -> www.includecpp
33a3467 
the SSL is only valid for www.*
@LilyWangL LilyWangL added requires:testing Needs tests added before merging category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed labels Jun 4, 2020
@ras0219-msft ras0219-msft merged commit 8706cb8 into microsoft:master Jun 5, 2020
@strega-nil strega-nil mentioned this pull request Jun 26, 2020
Merged
8 tasks
@strega-nil strega-nil deleted the includecpp-readme branch July 1, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LilyWangL LilyWangL

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed requires:testing Needs tests added before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@strega-nil @Hoikas @ras0219-msft @LilyWangL