Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[directxtk][directxtk12][directxtex][directxmesh] Update to latest version #11794

Merged
merged 3 commits into from
Jun 11, 2020
Merged

[directxtk][directxtk12][directxtex][directxmesh] Update to latest version #11794

merged 3 commits into from
Jun 11, 2020

Conversation

RT2Code
Copy link
Contributor

@RT2Code RT2Code commented Jun 5, 2020

No description provided.

LilyWangL
LilyWangL suggested changes Jun 8, 2020
View reviewed changes
ports/directxtex/portfile.cmake Show resolved Hide resolved
ports/directxtk12/portfile.cmake Show resolved Hide resolved
@LilyWangL LilyWangL added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Jun 8, 2020
@LilyWangL
Copy link
Contributor

Thanks for your PR. Now directxtex and directxmesh build x86-windows failed on CI with the following error:

Project "E:\buildtrees\directxtex\src\jun2020-dfac9b439c\DirectXTex_Desktop_2019.sln" on node 1 (Rebuild target(s)).
     1>E:\buildtrees\directxtex\src\jun2020-dfac9b439c\DirectXTex_Desktop_2019.sln.metaproj : error MSB4126: The specified solution configuration "Release|Win32" is invalid. Please specify a valid solution configuration using the Configuration and Platform properties (e.g. MSBuild.exe Solution.sln /p:Configuration=Debug /p:Platform="Any CPU") or leave those properties blank to use the default solution configuration. [E:\buildtrees\directxtex\src\jun2020-dfac9b439c\DirectXTex_Desktop_2019.sln]

@RT2Code RT2Code requested a review from LilyWangL June 10, 2020 22:28
@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 11, 2020
@dan-shaw dan-shaw merged commit 5c9511e into microsoft:master Jun 11, 2020
JangBoo pushed a commit to JangBoo/vcpkg that referenced this pull request Jun 18, 2020
@RT2Code @JangBoo
[directxtk][directxtk12][directxtex][directxmesh] Update to latest ve…
f92f016 
…rsion (microsoft#11794)

* [directxtk][directxtk12][directxtex][directxmesh] Update to latest version

* [directxtex][directxtk12] Remove deprecated function

* [directxtk][directxtk12][directxtex][directxmesh] Fix x86 platform build error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangL LilyWangL LilyWangL approved these changes

Assignees

@LilyWangL LilyWangL

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RT2Code @LilyWangL @dan-shaw