[libvpx] Add cmake config file #11795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows libvpx to be used with find_package(libvpx CONFIG REQUIRED) target_link_libraries(main PRIVATE libvpx::libvpx) Tested on all supported windows triplets.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Unofficial targets created by vcpkg ports are typically prefixed by |
|
That is a splendid suggestion @traversaro - I'll go ahead and make that change. |
|
I've done the change suggested by @traversaro, and I've also added a target guard in case the config gets loaded more than once (similar to what iconv is doing), since that seemed good practice. With those changes, the library can be used as follows: find_package(unofficial-libvpx CONFIG REQUIRED)
target_link_libraries(main PRIVATE unofficial::libvpx::libvpx) |
JackBoosY
added
the
category:port-feature
JackBoosY
suggested changes
Jun 10, 2020
JackBoosY
suggested changes
Jun 10, 2020
|
Thanks for the review. I think I've addressed all comments now. Let me know if anything else is needed. |
JackBoosY
approved these changes
Jun 11, 2020
JackBoosY
added
info:reviewed
|
Thanks for the PR! |
JangBoo
pushed a commit
to JangBoo/vcpkg
that referenced
this pull request
Jun 18, 2020
* [libvpx] Add cmake config file This allows libvpx to be used with find_package(libvpx CONFIG REQUIRED) target_link_libraries(main PRIVATE libvpx::libvpx) Tested on all supported windows triplets. * [libvpx] Rename cmake config file to make clear it is unofficial * [libvpx] Add cmake config target guard * [libvpx] Update version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows libvpx to be used with
find_package(libvpx CONFIG REQUIRED)
target_link_libraries(main PRIVATE libvpx::libvpx)
Describe the pull request
What does your PR fix? See above.
Which triplets are supported/not supported? Have you updated the CI baseline? Tested on all supported windows triplets. Should work also on linux/darwin provided the same library naming convention is used (vpx base name for release, vpxd base name for debug). If not, it is easy to add alternate names.
Does your PR follow the maintainer guide? Yes.