[vcpkg] Implementation of --x-binarysource=nuget (and friends) #12058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nteractive` binarysource.
|
that's the good news |
dan-shaw
reviewed
Jun 22, 2020
toolsrc/src/vcpkg/help.cpp
Outdated
| @@ -53,14 +54,14 @@ namespace vcpkg::Help | |||
| {"owns", command_topic_fn<Commands::Owns::COMMAND_STRUCTURE>}, | |||
| {"remove", command_topic_fn<Remove::COMMAND_STRUCTURE>}, | |||
| {"search", command_topic_fn<Commands::Search::COMMAND_STRUCTURE>}, | |||
| {"binarycaching", help_topic_binary_caching}, | |||
There was a problem hiding this comment.
Could probably be in alphabetical order
BillyONeal
requested changes
Jun 25, 2020
There was a problem hiding this comment.
This all looks good, the only thing I'm 'request changes' over are the missing unit tests for parts that should be easy to test:
XmlSerializer/XmlWriterStrings::find_first_ofreformat_version
(I made other test suggestions herein but I don't necessarily consider them easy enough to test to 'Request Changes' over, but seeing tests added for them would make me happy; and all other code review comments herein are nitpicks)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks everyone for the Code Review! |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…soft#12058) * [vcpkg] Initial implementation of --x-binarysource=nuget * [vcpkg] Remove double-double quoting of CMake arguments * [vcpkg] Update nuget.exe to 5.5.1 to support Azure DevOps Artifacts * [vcpkg] Enable batching of NuGet server calls with prefetch(). Add `interactive` binarysource. * [vcpkg] Add `nugetconfig` binary source * [vcpkg] Short circuit querying remote NuGet servers once all refs are found * [vcpkg] Add experimental help for binary caching * [vcpkg] Improved NuGet cache package descriptions and version formatting * [vcpkg] Rename `CmdLineBuilder::build()` to extract() * [vcpkg-help] Ascii-betize help topics * [vcpkg] Add tests for cmdlinebuilder. Improve handling of quotes and slashes. * [vcpkg] Addressing code review comments * [vcpkg] Add tests for vcpkg::reformat_version() * [vcpkg] Added test for vcpkg::generate_nuspec() * [vcpkg] Add tests for vcpkg::XmlSerializer * [vcpkg] Addressed code review comment * [vcpkg] Add test for vcpkg::Strings::find_first_of * [vcpkg] Fix machine-specific paths in test for vcpkg::generate_nuspec() Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--x-binarysource=nuget,--x-binarysource=nugetconfig, and--x-binarysource=interactive.Along the way, it adds bulk prefetch of packages (needed for good network performance) and updates our private copy of
nuget.exeto v5.5.1 for improved Azure DevOps support.This completes the
Backend #2andConfigurationitems of #11204.Remaining work before marking as ready to merge: