Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg-x-set-installed] Implement --dry-run #12132

Merged
merged 2 commits into from
Jun 27, 2020
Merged

[vcpkg-x-set-installed] Implement --dry-run #12132

merged 2 commits into from
Jun 27, 2020

Conversation

ras0219
Copy link
Contributor

@ras0219 ras0219 commented Jun 26, 2020

Implements --dry-run for vcpkg x-set-installed. This is required for the four-step-flow of #11204.

Example behaviors:

> .\vcpkg.exe x-set-installed --dry-run
The following packages will be removed:
    brotli:x86-windows
    cpprestsdk:x86-windows
    zlib:x86-windows

> .\vcpkg.exe x-set-installed --dry-run zlib
Detecting compiler hash for triplet x86-windows...
The following packages will be removed:
    brotli:x86-windows
    cpprestsdk:x86-windows

> .\vcpkg.exe x-set-installed --dry-run rapidjson
Detecting compiler hash for triplet x86-windows...
The following packages will be removed:
    brotli:x86-windows
    cpprestsdk:x86-windows
    zlib:x86-windows
The following packages will be built and installed:
    rapidjson[core]:x86-windows

> .\vcpkg.exe x-set-installed --dry-run cpprestsdk
Detecting compiler hash for triplet x86-windows...
All requested packages are currently installed.

BillyONeal
BillyONeal approved these changes Jun 26, 2020
View reviewed changes
toolsrc/src/vcpkg/dependencies.cpp Outdated Show resolved Hide resolved
toolsrc/src/vcpkg/dependencies.cpp Outdated Show resolved Hide resolved
@ras0219-msft ras0219-msft merged commit d47570b into microsoft:master Jun 27, 2020
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Jun 28, 2020
@Jimmy-Hu
Merge pull request #241 from microsoft/master
36441a7 
[vcpkg-x-set-installed] Implement --dry-run (microsoft#12132)
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@ras0219 @ras0219-msft
[vcpkg-x-set-installed] Implement --dry-run (microsoft#12132)
f0143cc 
* [vcpkg-x-set-installed] Implement --dry-run

* [vcpkg] Address code review comments

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ras0219 @BillyONeal @ras0219-msft