-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Implement --editable #12200
[vcpkg] Implement --editable #12200
Conversation
--editable suppresses binary caching and source re-extraction for packages listed on the command line (similar to --head). This fundamentally changes the port maintenance loop, so several example documents were updated. To avoid users having substantial changes suddenly destroyed by forgetting to pass --editable, "clean" sources have different extract locations. The undocumented command `build` implies `--editable`.
Thanks for asking. I am not fully understanding the goal here, I will check it better in the weekend looking at the code |
So basicly we should start using |
Thanks for the feedback! @cenit I'd be happy to answer any questions; it is also discussed a bit in https://github.com/ras0219-msft/vcpkg/blob/dev/roschuma/binarycaching-spec/docs/specifications/binarycaching.md#better-control-over-source-modifications
I don't quite understand what you mean by this, could you explain a bit more? |
Seems like your master branch is just too outdated. I tested it with zlib and the initial build was with your master branch. It had a extracted source dir of |
…roschuma/editable # Conflicts: # toolsrc/src/vcpkg/build.cpp # toolsrc/src/vcpkg/commands.ci.cpp # toolsrc/src/vcpkg/commands.setinstalled.cpp # toolsrc/src/vcpkg/commands.upgrade.cpp # toolsrc/src/vcpkg/export.cpp # toolsrc/src/vcpkg/install.cpp
@ras0219 sorry I had no time to test your PR. Maybe also my workflow is different from what you describe (I usually do not work in the buildtrees folder, I have some scripts to automatically create patches from commits in outside folders, tracked so that patches can be pushed for upstream PR easily). |
--editable suppresses binary caching and source re-extraction for packages listed on the command line (similar to --head). This fundamentally changes the port maintenance loop, so several example documents were updated. To avoid users having substantial changes suddenly destroyed by forgetting to pass --editable, "clean" sources have different extract locations. The undocumented command `build` implies `--editable`. Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
--editable
suppresses binary caching and source re-extraction for packages listed on the command line (similar to--head
).This fundamentally changes the port maintenance loop, so several example documents were updated. To avoid users having substantial changes suddenly destroyed by forgetting to pass --editable, "clean" sources have different extract locations.
The undocumented command
build
implies--editable
.See also #11204.
+@cenit +@Neumann-A as recent prolific contributors who can help confirm that this new inner-loop is still solid :)