You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoebeHui
added
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
and removed
category:vcpkg-feature
The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
labels
Jul 3, 2020
After further work on this, it seems that /p:CL_MPCount is not effective.
However, I think that using the CL environment variable is appropriate for this specific case for two reasons:
It is common practice elsewhere to specify flags via environment variables (CXXFLAGS)
This flag is a CL-specific flag -- if some other compiler was to be used inside msbuild, it is desirable for it to be ignored. Therefore, the CL environment variable functions perfectly for this use.
While testing, I found two additional significant performance issues:
file(COPY) is ~3x slower than xcopy for duplicating the source tree.
Spawning ~20 powershell.exe processes takes a long time during vcpkg_copy_tool_dependencies()
After addressing each of these points, the reported time for vcpkg build python3:x64-windows on my machine is down to 38.25s from 1.331mins -- ~2x faster.
However, I think that using the CL environment variable is appropriate for this specific case for two reasons:
It is common practice elsewhere to specify flags via environment variables (CXXFLAGS)
I would object much less to CL rather than _CL_. The former I've seen used in build systems sometimes, particularly make derived ones. The latter is the escape hatch for the former.
category:port-featureThe issue is with a library, which is requesting new capabilities that didn’t exist
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Title