Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wxWidgets port. #1231

Merged
merged 2 commits into from
Jun 10, 2017
Merged

Add wxWidgets port. #1231

merged 2 commits into from
Jun 10, 2017

Conversation

AlexanderTaeschner
Copy link
Contributor

Adresses #10.

@msftclas
Copy link

msftclas commented Jun 7, 2017

@AlexanderTaeschner,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@ras0219-msft ras0219-msft merged commit b7281d0 into microsoft:master Jun 10, 2017
@ras0219-msft
Copy link
Contributor

Thank you very much for the PR! This library has been a long time coming :)

While merging I made a few changes:

  • The code failed to link with a bunch of missing imports from libexpat, so I added the Build-Depends and forced the link by defining %_LINK_%. This isn't a great solution.
  • I switched to using vcpkg_from_github
  • I split the setting of RUNTIME_LIBS to track VCPKG_CRT_LINKAGE instead of VCPKG_LIBRARY_LINKAGE
  • A few other miscellaneous tweaks

@AlexanderTaeschner AlexanderTaeschner deleted the wxwidgets branch June 19, 2017 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderTaeschner @msftclas @ras0219-msft