[vcpkg] Add experimental x-azblob binary provider #13626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219-msft
force-pushed
the
dev/roschuma/azblob
branch
from
d5273c8 to
7a15b94
Compare
ras0219-msft
force-pushed
the
dev/roschuma/azblob
branch
from
7a15b94 to
1beaf81
Compare
JackBoosY
added
category:vcpkg-feature
2 tasks
…into dev/roschuma/azblob
BillyONeal
reviewed
Sep 28, 2020
BillyONeal
reviewed
Sep 29, 2020
BillyONeal
reviewed
Sep 29, 2020
BillyONeal
approved these changes
Sep 29, 2020
| static void clean_prepare_dir(Files::Filesystem& fs, const fs::path& dir) | ||
| { | ||
| fs.remove_all(dir, VCPKG_LINE_INFO); | ||
| bool created_last = fs.create_directories(dir, VCPKG_LINE_INFO); |
There was a problem hiding this comment.
Suggested change
| bool created_last = fs.create_directories(dir, VCPKG_LINE_INFO); | |
| bool created_last = fs.create_directory(dir, VCPKG_LINE_INFO); |
create_directories is really expensive and we should have already created the parents before we get here?
strega-nil
reviewed
Sep 29, 2020
This includes a note that it is currently experimental
BillyONeal
approved these changes
Oct 1, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* [vcpkg] Add experimental x-azblob binary provider * [vcpkg] Test azblob storage provider in CI * [vcpkg] Address some CR comments from microsoft#13639 * [vcpkg] Fixup azure-pipelines * [vcpkg] Fix regression where the downloaded package is purged before decompressing * [vcpkg] Further refactor vcpkg::Downloads * [vcpkg] Enable OSX for x-azblob testing * [vcpkg] Reduce diff against master * [vcpkg] Extract Downloads::details::split_uri_view * [vcpkg] Address PR comments * [vcpkg] Add testing and metrics for x-azblob * [vcpkg] Add docs for x-azblob This includes a note that it is currently experimental * [vcpkg] Address CR comments * [vcpkg] Revert pipeline changes except OSX to minimize disruption Co-authored-by: Robert Schumacher <roschuma@microsoft.com> Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an experimental binary provider backed by Azure Blob Storage.