Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[matplotplusplus] Add new port #13725

Merged
merged 27 commits into from
Apr 20, 2021
Merged

[matplotplusplus] Add new port #13725

merged 27 commits into from
Apr 20, 2021

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Sep 25, 2020

Describe the pull request

@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 14, 2020
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

Hi @myd7349

Is work still being done for this PR?

@myd7349
Copy link
Contributor Author

myd7349 commented Feb 8, 2021

Hi @myd7349

Is work still being done for this PR?

Hi. @NancyLi1013 Sorry for the long delay. I am still working on it. And I will spare some more time on it in the following days.

NancyLi1013
NancyLi1013 suggested changes Mar 8, 2021
View reviewed changes
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@myd7349 myd7349 marked this pull request as ready for review April 10, 2021 12:57
@myd7349
Copy link
Contributor Author

myd7349 commented Apr 10, 2021

Hi! @NancyLi1013 Sorry for the long delay. I think I have finished this port. Please review it again.

@myd7349 myd7349 mentioned this pull request Apr 10, 2021
Merged
NancyLi1013
NancyLi1013 suggested changes Apr 12, 2021
View reviewed changes
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 13, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for adding this port @myd7349.

Last thing needs to confirm the feature status. Can this build fine?

@NancyLi1013 NancyLi1013 added requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function and removed info:reviewed Pull Request changes follow basic guidelines labels Apr 13, 2021
@myd7349
Copy link
Contributor Author

myd7349 commented Apr 13, 2021

Hi! @NancyLi1013 For matplotplusplus, the OpenGL backend is still an experimental feature currently. I have tested it with x86-windows locally.

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Apr 13, 2021
@strega-nil strega-nil merged commit dd2255e into microsoft:master Apr 20, 2021
@myd7349 myd7349 deleted the matplotplusplus-init branch April 29, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myd7349 @NancyLi1013 @strega-nil