Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Add support to more paths for vcpkg usage hint #14303

Closed

Conversation

schultetwin1
Copy link
Contributor

Currently vcpkg will auto-generate a usage hint for installed packages.
These usage hints support the following paths under /share/:

  • <prefix>/(lib/<arch>|lib*|share)/cmake/<name>*/
  • <prefix>/(lib/<arch>|lib*|share)/<name>*/
  • <prefix>/<name>*/(lib/<arch>|lib*|share)/cmake/<name>*/
  • <prefix>/<name>*/(lib/<arch>|lib*|share)/<name>*/

This PR adds support for:

  • <prefix>/(lib/<arch>|lib*|share)/<name>*/(cmake|CMake)/
  • <prefix>/<name>*/(lib/<arch>|lib*|share)/<name>*/(cmake|CMake)/

You can read more about these paths here:
https://cmake.org/cmake/help/latest/command/find_package.html#search-procedure

Fixes #10881

Currently vcpkg will auto-generate a usage hint for installed packages.
These usage hints support the following paths under `share`:

* <prefix>/(lib/<arch>|lib*|share)/cmake/<name>*/
* <prefix>/(lib/<arch>|lib*|share)/<name>*/
* <prefix>/<name>*/(lib/<arch>|lib*|share)/cmake/<name>*/
* <prefix>/<name>*/(lib/<arch>|lib*|share)/<name>*/

This PR adds support for:

* <prefix>/(lib/<arch>|lib*|share)/<name>*/(cmake|CMake)/
* <prefix>/<name>*/(lib/<arch>|lib*|share)/<name>*/(cmake|CMake)/

You can read more about these paths here:
https://cmake.org/cmake/help/latest/command/find_package.html#search-procedure
@PhoebeHui PhoebeHui changed the title Add support to more paths for vcpkg usage hint [vcpkg] Add support to more paths for vcpkg usage hint Oct 30, 2020
@JackBoosY JackBoosY added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Oct 30, 2020
@JackBoosY
Copy link
Contributor

JackBoosY commented Oct 30, 2020

Thanks for this PR! Sadly, since all cmake files should be placed in <prefix>/share/<name> in vcpkg, this PR is invalid.

@schultetwin1
Copy link
Contributor Author

@JackBoosY

since all cmake files should be placed in /share/ in vcpkg

Is this documented somewhere? I looked but couldn't find anything. <prefix>/share/<name>/CMake is a valid install path for a CMake module, why does vcpkg care where it gets installed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vcpkg install: Usage hint for CMake find_package, incomplete support for possible paths
2 participants