Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pegtl] Update to 3.0.0 release #14841

Merged
merged 3 commits into from
Dec 7, 2020
Merged

[pegtl] Update to 3.0.0 release #14841

merged 3 commits into from
Dec 7, 2020

Conversation

wravery
Copy link
Contributor

@wravery wravery commented Nov 30, 2020

Describe the pull request

  • What does your PR fix?

https://github.com/taocpp/PEGTL just released version 3.0.0. This syncs the vcpkg port with that release tag.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

This is a header-only library with no dependencies outside of the C++17 standard library. It does require std::filesystem, but it has fallback logic in CMake to auto-detect the std::experimental::filesystem implementation or additional linked library requirements that are required on older toolchains.

Yes.

@JonLiu1993 JonLiu1993 self-assigned this Nov 30, 2020
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 30, 2020
@JonLiu1993 JonLiu1993 self-requested a review November 30, 2020 02:15
@wravery wravery marked this pull request as ready for review November 30, 2020 04:16
@JonLiu1993 JonLiu1993 requested review from JackBoosY and removed request for JonLiu1993 December 1, 2020 02:57
@JackBoosY
Copy link
Contributor

/mnt/vcpkg-ci/installed/x64-linux/include/tao/pegtl/read_input.hpp:7:10: fatal error: filesystem: No such file or directory
 #include <filesystem>
          ^~~~~~~~~~~~
compilation terminated.

See https://stackoverflow.com/questions/39231363/fatal-error-filesystem-no-such-file-or-directory.
Can you please fix it in this PR?

Thanks.

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

No achives were found in the results, will rerun the pipeline test.

@wravery
Copy link
Contributor Author

wravery commented Dec 1, 2020

Trouble is PEGTL has dropped support for those compiler versions (so cppgraphqlgen, which depends on PEGTL did as well) since they don't fully implement C++17. To fix it would mean patching PEGTL in a way that I don't think the upstream maintainer would want to take. Is it better to patch the port (and see about upstreaming the patch later), or is there a process for deprecating these older compiler toolchains for a given port?

@JackBoosY
Copy link
Contributor

@wravery We want to use the patch method accepted by upstream, do you have any ideas?

@wravery
Copy link
Contributor Author

wravery commented Dec 1, 2020

We've sort of been discussing this in taocpp/PEGTL#216, I have an idea that might work. Let me see if the project owners like it.

@wravery
Copy link
Contributor Author

wravery commented Dec 6, 2020

Accidentally force pushed the reset instead of the replacement.

@wravery wravery reopened this Dec 6, 2020
@wravery wravery marked this pull request as draft December 6, 2020 20:38
@wravery wravery marked this pull request as ready for review December 6, 2020 21:44
ports/pegtl/CONTROL Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 7, 2020
@BillyONeal BillyONeal merged commit af87209 into microsoft:master Dec 7, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants