-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pegtl] Update to 3.0.0 release #14841
Conversation
See https://stackoverflow.com/questions/39231363/fatal-error-filesystem-no-such-file-or-directory. Thanks. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
No achives were found in the results, will rerun the pipeline test. |
Trouble is PEGTL has dropped support for those compiler versions (so cppgraphqlgen, which depends on PEGTL did as well) since they don't fully implement C++17. To fix it would mean patching PEGTL in a way that I don't think the upstream maintainer would want to take. Is it better to patch the port (and see about upstreaming the patch later), or is there a process for deprecating these older compiler toolchains for a given port? |
@wravery We want to use the patch method accepted by upstream, do you have any ideas? |
We've sort of been discussing this in taocpp/PEGTL#216, I have an idea that might work. Let me see if the project owners like it. |
Accidentally force pushed the reset instead of the replacement. |
Thanks for your contribution! |
Describe the pull request
https://github.com/taocpp/PEGTL just released version 3.0.0. This syncs the vcpkg port with that release tag.
This is a header-only library with no dependencies outside of the C++17 standard library. It does require
std::filesystem
, but it has fallback logic in CMake to auto-detect thestd::experimental::filesystem
implementation or additional linked library requirements that are required on older toolchains.Yes.