[vcpkg] Fix regression in error messages with registries/versioning #15709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the versioning and registries PRs landing, a regression was introduced where syntax issues with builtin ports were no longer displayed.
Before:
After:
In addition to fixing this regression, this PR cleans up a few layers of duplicate code or impedance mismatch between APIs (such as loading and parsing from disk the same files multiple times). Especially, this implements
PathsPortfileProvider
entirely in terms of the new providers.