[mnn,flatbuffers] add a new port and patch #15717

luncliff · 2021-01-17T18:23:42Z

Changes

Create a new port for https://github.com/alibaba/mnn. Focused general desktop build configurations.

Patches

ports/flatbuffers/fix-issue-6036.patch

Workaround for google/flatbuffers#6036. The patch can be removed when the flatbuffers package gets the next release.

use-packages-and-install.patch

The project embedded several libraries that are available in VcPkg. It modifies the CMakeLists.txt files to use those packages.

fix-dllexport.patch

Some symbols become duplicated when MNN.dll is being generated. The scripts of the project don't generate executables in the Windows platform, so it seems like this issue is not reported.
~~This patch makes minimum changes to enable the tools feature.~~

Extracted all code changes to alibaba/MNN#1391

Feature

Supports 5 features.

test: Generate train/benchmark executables
tools: Not available for Windows
opencl, vulkan, cuda: API backends that use packages in VcPkg
metal: API backend only for the Apple platform

Known Issues

cuda errors when Ninja in Windows environment. PREFER_NINJA won't be used in this case.
Notice that CUDA installation may affect the build result.

Using the metal feature may require Xcode CLI tools configuration in the environment. Please reference
gfx-rs/gfx#2309 (comment)

Which triplets are supported/not supported?

arm, uwp, ios, android won't be considered in this PR. (Probably in the next port update?)

x64-windows
x86-windows
x64-osx
x64-linux

Does your PR follow the maintainer guide?

Checked!

ports/mnn/001-use-packages.patch

ports/mnn/portfile.cmake

scripts/ci.baseline.txt

JackBoosY

Please run command vcpkg x-add-version --all then commit the changes.

JackBoosY · 2021-02-01T02:39:22Z

Please get failure logs here.

luncliff · 2021-02-01T03:26:31Z

Thanks for the check. I'm currently struggling with Cuda build. May I apply your suggestions after 3,4 commits later?

…

On Mon, Feb 1, 2021, 11:39 AM Jack·Boos·Yu ***@***.***> wrote: Please get failure logs here <https://dev.azure.com/vcpkg/public/_build/results?buildId=48695&view=artifacts&pathAsName=false&type=publishedArtifacts> . — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#15717 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADLSYEYXJ5CLYZL5VJXVSYDS4YH6PANCNFSM4WGJTAYQ> .

JackBoosY · 2021-02-01T06:02:50Z

@luncliff Fine.

luncliff · 2021-02-03T11:28:04Z

Issues - `cuda` feature

This note is for future visitors

Encountered Issue related to google/flatbuffers#6036. Looking for a workaround to deal with this.

With flatbuffers 1.12, mnn[cuda,test,tools] will fail with the following log.

CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:145 (message):
    Command failed: "C:/Program Files/CMake/bin/cmake.exe" --build . --config Debug --target install -- -v -j13
    Working Directory: D:/vcpkg/buildtrees/mnn/x64-windows-dbg
    See logs for more information:
      D:\vcpkg\buildtrees\mnn\install-x64-windows-dbg-out.log

The file says, CUDA file's can't be compiled with the implementation.

D:\vcpkg\installed\x64-windows\include\flatbuffers/flatbuffers.h(1875): error: function "flatbuffers::vector_downward::operator=(const flatbuffers::vector_downward &)"
(1002): here cannot be referenced -- it is a deleted function

1 error detected in the compilation of "D:/vcpkg/buildtrees/mnn/src/1.1.0-b6e0383c18/source/backend/cuda/execution/DeconvSingleInputExecution.cu".
DeconvSingleInputExecution.cu
CMake Error at MNN_Cuda_Main_generated_DeconvSingleInputExecution.cu.obj.Debug.cmake:280 (message):
  Error generating file
  D:/vcpkg/buildtrees/mnn/x64-windows-dbg/source/backend/cuda/CMakeFiles/MNN_Cuda_Main.dir/execution/./MNN_Cuda_Main_generated_DeconvSingleInputExecution.cu.obj

After fixing flatbuffers.h to use the pointer, the CUDA sources can be compiled.

/** flatbuffers.h 1861 */
  /// @cond FLATBUFFERS_INTERNAL
  template<typename T> struct TableKeyComparator {
    TableKeyComparator(vector_downward &buf) : buf_(&buf) {}
    TableKeyComparator(const TableKeyComparator &other) : buf_(other.buf_) {}
    bool operator()(const Offset<T> &a, const Offset<T> &b) const {
      auto table_a = reinterpret_cast<T *>(buf_->data_at(a.o));
      auto table_b = reinterpret_cast<T *>(buf_->data_at(b.o));
      return table_a->KeyCompareLessThan(table_b);
    }
    vector_downward *buf_;

   private:
    TableKeyComparator &operator=(const TableKeyComparator &other) {
      buf_ = other.buf_;
      return *this;
    }
  };
  /// @endcond

* create a patch, embed copyright * touching install options

* feature cuda reqires cudnn

* update port SHA

* patch creates version config.cmake * run vcpkg_copy_tools for 'tools' feature

* make PREFER_NINJA optional for 'cuda' feature

luncliff · 2021-02-10T12:08:19Z

@JackBoosY , I want to check the log files in the failed builds, but looks like artifacts are about dependent packages. Is there another way to can .logs?
The install was successful for my Ubuntu on Docker and Mac device. IMO there is a subtle difference from CI environment...

JackBoosY · 2021-02-18T05:53:59Z

[261/263] /usr/bin/c++ -DMNN_SUPPORT_TFLITE_QUAN -DMNN_USE_SSE -DMNN_USE_THREAD_POOL -DMNN_VERSION=\"1.1.0.0-d6795ad\" -DMNN_VERSION_MAJOR=1 -DMNN_VERSION_MINOR=1 -DMNN_VERSION_PATCH=0 -I/mnt/vcpkg-ci/buildtrees/mnn/src/1.1.0-d41eed3663.clean/include -I/mnt/vcpkg-ci/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source -I/mnt/vcpkg-ci/buildtrees/mnn/src/1.1.0-d41eed3663.clean/express -I/mnt/vcpkg-ci/buildtrees/mnn/src/1.1.0-d41eed3663.clean/tools -I/mnt/vcpkg-ci/buildtrees/mnn/src/1.1.0-d41eed3663.clean/schema/current -I/mnt/vcpkg-ci/buildtrees/mnn/src/1.1.0-d41eed3663.clean/3rd_party/half -I/mnt/vcpkg-ci/installed/x64-linux/share/rapidjson/../../include -isystem /mnt/vcpkg-ci/installed/x64-linux/include -fPIC -std=c++11 -D__STRICT_ANSI__ -O3 -fvisibility-inlines-hidden -fvisibility=hidden -fomit-frame-pointer -fstrict-aliasing -ffunction-sections -fdata-sections -ffast-math -fno-rtti -fno-exceptions  -O3 -DNDEBUG   -fPIC -std=gnu++11 -MD -MT express/CMakeFiles/MNNExpress.dir/Expr.cpp.o -MF express/CMakeFiles/MNNExpress.dir/Expr.cpp.o.d -o express/CMakeFiles/MNNExpress.dir/Expr.cpp.o -c /mnt/vcpkg-ci/buildtrees/mnn/src/1.1.0-d41eed3663.clean/express/Expr.cpp
/mnt/vcpkg-ci/buildtrees/mnn/src/1.1.0-d41eed3663.clean/express/Expr.cpp: In static member function ‘static void MNN::Express::Variable::save(const std::vector<MNN::Express::VARP>&, MNN::NetT*)’:
/mnt/vcpkg-ci/buildtrees/mnn/src/1.1.0-d41eed3663.clean/express/Expr.cpp:819:6: warning: ‘__builtin___snprintf_chk’ output may be truncated before the last format character [-Wformat-truncation=]
 void Variable::save(const std::vector<VARP>& vars, NetT* dest) {
      ^~~~~~~~
In file included from /usr/include/stdio.h:862:0,
                 from /usr/include/c++/7/cstdio:42,
                 from /usr/include/c++/7/ext/string_conversions.h:43,
                 from /usr/include/c++/7/bits/basic_string.h:6361,
                 from /usr/include/c++/7/string:52,
                 from /usr/include/c++/7/stdexcept:39,
                 from /usr/include/c++/7/array:39,
                 from /usr/include/c++/7/tuple:39,
                 from /usr/include/c++/7/functional:54,
                 from /mnt/vcpkg-ci/buildtrees/mnn/src/1.1.0-d41eed3663.clean/include/MNN/expr/Expr.hpp:12,
                 from /mnt/vcpkg-ci/buildtrees/mnn/src/1.1.0-d41eed3663.clean/express/Expr.cpp:10:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:65:44: note: ‘__builtin___snprintf_chk’ output between 2 and 11 bytes into a destination of size 10
        __bos (__s), __fmt, __va_arg_pack ());
                                            ^

Please get failure logs here.

luncliff · 2021-02-18T06:27:33Z

Thanks. I just checked both logs.

Error from x64-osx looks similar to gfx-rs/gfx#2309. Kind of Xcode CLI tools issue in the environment... I will do more survey on it.

[238/291] cd /Volumes/data/buildtrees/mnn/x64-osx-dbg && xcrun -sdk macosx metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalBackend.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalBinary.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalCast.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalConvolution.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalConvolution1x1.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalConvolutionActivation.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalConvolutionDepthwise.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalConvolutionGEMM.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalConvolutionWinograd.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalDeconvolution.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalDefine.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalDequantize.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalEltwise.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalFixedPoint.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalMatMul.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalPReLU.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalPooling.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalROIPooling.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalReLU.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalReLU6.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalReduction.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalResize.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalScale.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalUnary.metal -o /Volumes/data/buildtrees/mnn/x64-osx-dbg/mnn.metallib
FAILED: mnn.metallib 
cd /Volumes/data/buildtrees/mnn/x64-osx-dbg && xcrun -sdk macosx metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalBackend.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalBinary.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalCast.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalConvolution.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalConvolution1x1.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalConvolutionActivation.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalConvolutionDepthwise.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalConvolutionGEMM.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalConvolutionWinograd.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalDeconvolution.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalDefine.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalDequantize.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalEltwise.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalFixedPoint.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalMatMul.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalPReLU.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalPooling.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalROIPooling.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalReLU.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalReLU6.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalReduction.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalResize.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalScale.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-d41eed3663.clean/source/backend/metal/MetalUnary.metal -o /Volumes/data/buildtrees/mnn/x64-osx-dbg/mnn.metallib
xcrun: error: unable to find utility "metal", not a developer tool or in PATH

x64-linux report looks like a simple problem. I will add more commits after testing with my local machine.

CMake Error at scripts/cmake/vcpkg_fixup_cmake_targets.cmake:126 (message):
  '/mnt/vcpkg-ci/packages/mnn_x64-linux/debug/share/mnn' does not exist.
Call Stack (most recent call first):
  ports/mnn/portfile.cmake:74 (vcpkg_fixup_cmake_targets)
  scripts/ports.cmake:131 (include)

JackBoosY · 2021-02-20T02:44:59Z

Only osx regression:

[238/291] cd /Volumes/data/buildtrees/mnn/x64-osx-dbg && xcrun -sdk macosx metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalBackend.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalBinary.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalCast.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalConvolution.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalConvolution1x1.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalConvolutionActivation.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalConvolutionDepthwise.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalConvolutionGEMM.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalConvolutionWinograd.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalDeconvolution.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalDefine.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalDequantize.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalEltwise.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalFixedPoint.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalMatMul.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalPReLU.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalPooling.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalROIPooling.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalReLU.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalReLU6.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalReduction.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalResize.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalScale.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalUnary.metal -o /Volumes/data/buildtrees/mnn/x64-osx-dbg/mnn.metallib
FAILED: mnn.metallib 
cd /Volumes/data/buildtrees/mnn/x64-osx-dbg && xcrun -sdk macosx metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalBackend.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalBinary.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalCast.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalConvolution.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalConvolution1x1.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalConvolutionActivation.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalConvolutionDepthwise.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalConvolutionGEMM.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalConvolutionWinograd.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalDeconvolution.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalDefine.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalDequantize.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalEltwise.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalFixedPoint.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalMatMul.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalPReLU.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalPooling.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalROIPooling.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalReLU.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalReLU6.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalReduction.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalResize.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalScale.metal /Users/vagrant/Data/buildtrees/mnn/src/1.1.0-7b4f0aaa49.clean/source/backend/metal/MetalUnary.metal -o /Volumes/data/buildtrees/mnn/x64-osx-dbg/mnn.metallib
xcrun: error: unable to find utility "metal", not a developer tool or in PATH

* update port SHA

luncliff · 2021-02-21T16:07:01Z

Before c6cd2d7, when it turns out the build is targeting the Apple platforms, the port enabled metal feature automatically.

mnn[metal] should be available in a normal local developer environment, but CI may not.
Considering such cases, after c6cd2d7, the port mnn will be CPU only mode unless it is requested explicitly with mnn[metal].

ports/mnn/copyright

ports/mnn/fix-dllexport.patch

ports/mnn/portfile.cmake

* possibly break osx build with the chnage

ports/mnn/portfile.cmake

versions/m-/mnn.json

luncliff · 2021-03-19T03:09:58Z

@JackBoosY. I'd like to try ARM/Android support of this port.
Is there a plan for the merge of reviewed PRs? Thanks for your team's works :)

JackBoosY · 2021-03-19T06:21:56Z

Ping @ras0219 @ras0219-msft for merge this PR.

ras0219-msft

Thanks for the PR! Looks good to merge once my comments are addressed :)

ports/mnn/use-package-and-install.patch

ports/mnn/portfile.cmake

* find_package(CUDNN) in patch * use vcpkg_download_distfile * ONLY_STATIC_LIBRARY for Windows

ras0219-msft

One more needed change :)

ports/mnn/portfile.cmake

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>

ras0219-msft · 2021-03-23T21:39:04Z

LGTM, thanks for the new library!

luncliff marked this pull request as draft January 17, 2021 18:23

JackBoosY self-assigned this Jan 18, 2021

JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 18, 2021

JackBoosY suggested changes Jan 18, 2021

View reviewed changes

luncliff and others added 7 commits February 10, 2021 11:20

[mnn] add a new port

72e21ea

* create a patch, embed copyright * touching install options

[mnn] fix windows install

8a8cdda

* feature cuda reqires cudnn

[flatbuffers] add patch for TableKeyComparator

8840876

* update port SHA

[mnn] disable arm support

46f91eb

[mnn] update port SHA

916dfaa

* patch creates version config.cmake * run vcpkg_copy_tools for 'tools' feature

[mnn] remove bin when non-Windows

f7dd563

* make PREFER_NINJA optional for 'cuda' feature

[mnn] fix wrong macro

0696586

luncliff marked this pull request as ready for review February 10, 2021 12:04

luncliff changed the title ~~[mnn] add a new port~~ [mnn,flatbuffers] add a new port and patch Feb 10, 2021

luncliff requested a review from JackBoosY February 17, 2021 03:30

JackBoosY added the requires:author-response label Feb 18, 2021

luncliff marked this pull request as draft February 19, 2021 06:56

[mnn] rename install path to lowercase

bf49ab7

[mnn] make 'metal' feature optional

c6cd2d7

* update port SHA

luncliff marked this pull request as ready for review February 21, 2021 16:00

JackBoosY suggested changes Feb 22, 2021

View reviewed changes

JackBoosY removed the requires:author-response label Mar 1, 2021

JackBoosY suggested changes Mar 1, 2021

View reviewed changes

ports/mnn/portfile.cmake Outdated Show resolved Hide resolved

JackBoosY added the requires:author-response label Mar 1, 2021

[mnn] remove version.cmake generation

35879cf

* possibly break osx build with the chnage

JackBoosY suggested changes Mar 2, 2021

View reviewed changes

ports/mnn/portfile.cmake Outdated Show resolved Hide resolved

Update ports/mnn/portfile.cmake

536f616

JackBoosY suggested changes Mar 2, 2021

View reviewed changes

versions/m-/mnn.json Outdated Show resolved Hide resolved

Update versions/m-/mnn.json

54c8508

JackBoosY approved these changes Mar 2, 2021

View reviewed changes

JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 2, 2021

ras0219-msft requested changes Mar 19, 2021

View reviewed changes

luncliff added 3 commits March 20, 2021 20:04

[mnn] apply PR feedback

c12b914

* find_package(CUDNN) in patch * use vcpkg_download_distfile * ONLY_STATIC_LIBRARY for Windows

[mnn] create share folder and move copyright

42ee8f4

[mnn] update git-tree SHA

b52c077

luncliff requested a review from ras0219-msft March 22, 2021 02:32

ras0219-msft requested changes Mar 22, 2021

View reviewed changes

ports/mnn/portfile.cmake Outdated Show resolved Hide resolved

JackBoosY added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Mar 23, 2021

luncliff and others added 2 commits March 23, 2021 10:43

Update ports/mnn/portfile.cmake

ff8e018

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>

[mnn] update git-tree SHA

8cc832b

JackBoosY removed the requires:author-response label Mar 23, 2021

JackBoosY requested a review from ras0219-msft March 23, 2021 08:35

JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Mar 23, 2021

luncliff mentioned this pull request Mar 23, 2021

[flatbuffers] support iOS triplets #16843

Merged

ras0219-msft merged commit b35f1ed into microsoft:master Mar 23, 2021

luncliff deleted the port/mnn branch March 25, 2021 13:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[mnn,flatbuffers] add a new port and patch #15717

[mnn,flatbuffers] add a new port and patch #15717

luncliff commented Jan 17, 2021 •

edited

Loading

JackBoosY left a comment

JackBoosY commented Feb 1, 2021

luncliff commented Feb 1, 2021 via email

JackBoosY commented Feb 1, 2021

luncliff commented Feb 3, 2021 •

edited

Loading

luncliff commented Feb 10, 2021

JackBoosY commented Feb 18, 2021

luncliff commented Feb 18, 2021 •

edited

Loading

JackBoosY commented Feb 20, 2021

luncliff commented Feb 21, 2021 •

edited

Loading

luncliff commented Mar 19, 2021

JackBoosY commented Mar 19, 2021

ras0219-msft left a comment

ras0219-msft left a comment

ras0219-msft commented Mar 23, 2021

[mnn,flatbuffers] add a new port and patch #15717

[mnn,flatbuffers] add a new port and patch #15717

Conversation

luncliff commented Jan 17, 2021 • edited Loading

Changes

Patches

ports/flatbuffers/fix-issue-6036.patch

use-packages-and-install.patch

fix-dllexport.patch

Feature

Known Issues

Which triplets are supported/not supported?

Does your PR follow the maintainer guide?

JackBoosY left a comment

Choose a reason for hiding this comment

JackBoosY commented Feb 1, 2021

luncliff commented Feb 1, 2021 via email

JackBoosY commented Feb 1, 2021

luncliff commented Feb 3, 2021 • edited Loading

Issues - cuda feature

luncliff commented Feb 10, 2021

JackBoosY commented Feb 18, 2021

luncliff commented Feb 18, 2021 • edited Loading

JackBoosY commented Feb 20, 2021

luncliff commented Feb 21, 2021 • edited Loading

luncliff commented Mar 19, 2021

JackBoosY commented Mar 19, 2021

ras0219-msft left a comment

Choose a reason for hiding this comment

ras0219-msft left a comment

Choose a reason for hiding this comment

ras0219-msft commented Mar 23, 2021

luncliff commented Jan 17, 2021 •

edited

Loading

luncliff commented Feb 3, 2021 •

edited

Loading

Issues - `cuda` feature

luncliff commented Feb 18, 2021 •

edited

Loading

luncliff commented Feb 21, 2021 •

edited

Loading