Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ogre] Do not use strict mode by default in ogre for backward compatibility #15789

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

traversaro
Copy link
Contributor

Describe the pull request

@traversaro
Copy link
Contributor Author

fyi @j-rivero the regression introduced by #15194 will probably affect CI jobs in which you use ogre for ignition-rendering/gazebo if you updated vcpkg, a possible workaround is robotology/robotology-superbuild-dependencies-vcpkg@2666dfd .

@dweckmann
Copy link
Contributor

Well, indeed, we had the same problem. Our software (https://github.com/IRCAD/sight) used ogre with the non strict resource manager. Even if we had fixed our code to be able to work with "strict" mode, my opinion is that the non strict should also be the default since 'strict' code will also work, even if it may be a bit slower when loading resource

@traversaro
Copy link
Contributor Author

Well, indeed, we had the same problem. Our software (https://github.com/IRCAD/sight) used ogre with the non strict resource manager. Even if we had fixed our code to be able to work with "strict" mode, my opinion is that the non strict should also be the default since 'strict' code will also work, even if it may be a bit slower when loading resource

Thanks @dweckmann !

@JackBoosY
Copy link
Contributor

Reasonable, thanks!

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines labels Jan 22, 2021
@dan-shaw dan-shaw merged commit 42bb41f into microsoft:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants