[lua] Export cmake targets, rewrite CMakeLists and delete usage #15921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
category:port-bug
|
@Williamxin Can you please test this PR? Thanks. |
thank you! |
now cmake can finish on my centos, the problem has been solved, thank you |
NancyLi1013
approved these changes
Feb 1, 2021
ras0219-msft
requested changes
Feb 2, 2021
|
@ras0219-msft Do you have any other questions? |
|
I tried this PR on Ubuntu 20.10 and still face a problem: see here. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout fa1bbe097b26678e3fd992173b62279c071c422b -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index ae0396a..6186ece 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3858,7 +3858,7 @@
},
"lua": {
"baseline": "5.4.3",
- "port-version": 1
+ "port-version": 2
},
"luabridge": {
"baseline": "2.6",
diff --git a/versions/l-/lua.json b/versions/l-/lua.json
index fd0f4da..399d6e8 100644
--- a/versions/l-/lua.json
+++ b/versions/l-/lua.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "d4f0d15b931f54c58381e6896517410ef7778cd8",
+ "version-string": "5.4.3",
+ "port-version": 2
+ },
{
"git-tree": "0e8966273a1a18cf591cf78046d345c74941a37d",
"version-string": "5.4.3",
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout fa1bbe097b26678e3fd992173b62279c071c422b -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index ae0396a..6186ece 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3858,7 +3858,7 @@
},
"lua": {
"baseline": "5.4.3",
- "port-version": 1
+ "port-version": 2
},
"luabridge": {
"baseline": "2.6",
diff --git a/versions/l-/lua.json b/versions/l-/lua.json
index fd0f4da..7503666 100644
--- a/versions/l-/lua.json
+++ b/versions/l-/lua.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "10e0f0c1ebdf0c22e904c2da968a0a5044917a1f",
+ "version-string": "5.4.3",
+ "port-version": 2
+ },
{
"git-tree": "0e8966273a1a18cf591cf78046d345c74941a37d",
"version-string": "5.4.3",
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout fa1bbe097b26678e3fd992173b62279c071c422b -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index ae0396a..6186ece 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3858,7 +3858,7 @@
},
"lua": {
"baseline": "5.4.3",
- "port-version": 1
+ "port-version": 2
},
"luabridge": {
"baseline": "2.6",
diff --git a/versions/l-/lua.json b/versions/l-/lua.json
index fd0f4da..229dc27 100644
--- a/versions/l-/lua.json
+++ b/versions/l-/lua.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "3e9ae23186ccbf4e89af8d32a4f8a23d0194dea5",
+ "version-string": "5.4.3",
+ "port-version": 2
+ },
{
"git-tree": "0e8966273a1a18cf591cf78046d345c74941a37d",
"version-string": "5.4.3",
|
The tensorflow-cc regression will be resolved by #19165. |
JackBoosY
added
depends:different-pr
added 2 commits
August 2, 2021 02:36
NancyLi1013
approved these changes
Aug 2, 2021
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
FindLua.cmakesets the default search path, and the header file is included in lua-version by default, it is impossible to find the lua generated by vcpkg correctly, export the targets and modify the cmake wrapper to adapt to the search method of the old version.Fixes #15497.