Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libffi] Fix processors #16285

Merged
merged 5 commits into from
Apr 2, 2021
Merged

[libffi] Fix processors #16285

merged 5 commits into from
Apr 2, 2021

Conversation

autoantwort
Copy link
Contributor

Describe the pull request

@autoantwort autoantwort mentioned this pull request Feb 18, 2021
Closed
ras0219-msft
ras0219-msft requested changes Feb 19, 2021
View reviewed changes
ports/libffi/CMakeLists.txt Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 self-assigned this Feb 19, 2021
@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels Feb 19, 2021
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 changed the title Libffi [libffi] Fix processors Feb 20, 2021
ras0219-msft
ras0219-msft approved these changes Feb 21, 2021
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a bit more rearranging to better account for previous behavior.

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Feb 22, 2021
@autoantwort
Copy link
Contributor Author

@ras0219-msft you approved the changes, but merge is still needed

@ras0219-msft ras0219-msft merged commit 45bc3d3 into microsoft:master Apr 2, 2021
@ras0219-msft
Copy link
Contributor

ras0219-msft commented Apr 2, 2021 •
edited
Loading

If the CI is still running, I approve but can't merge yet :) Thanks for the PR!

@autoantwort autoantwort deleted the libffi branch September 1, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@ras0219-msft ras0219-msft ras0219-msft approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libffi] build failure on macOS
3 participants
@autoantwort @NancyLi1013 @ras0219-msft