Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg.cmake] add VCPKG_INSTALLED_DIR as a settable option #16303

Merged
merged 1 commit into from
Jun 10, 2021
Merged

[vcpkg.cmake] add VCPKG_INSTALLED_DIR as a settable option #16303

merged 1 commit into from
Jun 10, 2021

Conversation

strega-nil
Copy link
Contributor

This is something that #16061 tried to do, but screwed up; see #16293 . This one fixes that.

@Neumann-A
Copy link
Contributor

Neumann-A commented Feb 19, 2021 •
edited
Loading

You need to also fix the 50 matches for _VCPKG_INSTALLED_DIR in /ports/*. Otherwise you break the wrappers and so on.

@strega-nil
Copy link
Contributor Author

@Neumann-A how about the new version, which includes back-compat considerations?

@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels Feb 20, 2021
@strega-nil strega-nil force-pushed the vcpkg.cmake-vcpkg-installed-dir branch from f1b5a7e to 4f05bf9 Compare March 11, 2021 19:05
@strega-nil
[vcpkg.cmake] add VCPKG_INSTALLED_DIR as a settable option
01b2222 
this change does not actually make any changes,
except that `VCPKG_INSTALLED_DIR` and sets `_VCPKG_INSTALLED_DIR`.
In the future, we can start using `VCPKG_INSTALLED_DIR`
completely.
@strega-nil strega-nil force-pushed the vcpkg.cmake-vcpkg-installed-dir branch from 4f05bf9 to 01b2222 Compare April 2, 2021 22:37
@strega-nil
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ras0219-msft
Copy link
Contributor

ping @strega-nil that this LGTM

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jun 10, 2021
@strega-nil-ms strega-nil-ms merged commit f51c703 into microsoft:master Jun 10, 2021
@strega-nil-ms
Copy link
Contributor

Thanks robert!

@strega-nil strega-nil deleted the vcpkg.cmake-vcpkg-installed-dir branch June 30, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@strega-nil @Neumann-A @ras0219-msft @strega-nil-ms @JackBoosY