Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scripts/vcpkgTools.xml] add specs for gsutil #16462

Merged
merged 2 commits into from
Jun 9, 2021
Merged

[scripts/vcpkgTools.xml] add specs for gsutil #16462

merged 2 commits into from
Jun 9, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 28, 2021

Add specifications to download gsutil for Linux, Windows, and macOS.

  • What does your PR fix? Fixes #

Fixes #16288, after the corresponding PR in vcpkg-tool (microsoft/vcpkg-tool#19)

  • Which triplets are supported/not supported? Have you updated the CI baseline?

N/A

Yes.

@coryan coryan marked this pull request as ready for review February 28, 2021 19:39
@JackBoosY JackBoosY requested a review from ras0219-msft March 1, 2021 03:05
@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed requires:discussion labels Mar 1, 2021
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Mar 1, 2021
scripts/vcpkgTools.xml Outdated Show resolved Hide resolved
@JackBoosY JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label Mar 2, 2021
@JackBoosY
Copy link
Contributor

Ping @coryan for response, Is work still being done for this PR?

@coryan
Copy link
Contributor Author

coryan commented May 25, 2021

Work is still pending, I have been distracted by my main job and life.

PS: I think I need to change the tarball that gets downloaded, there is a larger one that includes gsutil.cmd which seems more friendly for Windows.

@JackBoosY JackBoosY requested a review from ras0219-msft June 7, 2021 07:12
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 7, 2021
@JackBoosY
Copy link
Contributor

LGTM on my side.

@strega-nil-ms
Copy link
Contributor

LGTM, thanks!

@strega-nil-ms strega-nil-ms merged commit a4838ab into microsoft:master Jun 9, 2021
@coryan coryan deleted the feat-add-description-for-gsutil branch March 11, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vcpkg] Add gsutil to list of downloadable tools in
4 participants