[kf5auth] new port #16559
Merged
[kf5auth] new port #16559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
added
the
category:new-port
NancyLi1013
suggested changes
Mar 8, 2021
|
Wow, Seems you need to rebase this PR now, many changes were brought in this PR. Or you can open a new pull request to adding this port. |
Indeed, will be rebasing, but still waiting for #17268 to get merged. |
NancyLi1013
added
the
depends:different-pr
|
@NancyLi1013 #17268 got merged. Rebased and ready to go. The static build failure seems to be due to intermittent CI/CD connectivity issue. |
NancyLi1013
removed
the
depends:different-pr
NancyLi1013
suggested changes
May 24, 2021
|
@NancyLi1013 all fixed, thanks for the instructions. |
NancyLi1013
approved these changes
May 26, 2021
NancyLi1013
added
info:reviewed
|
LGTM now, thanks for adding this port. @wrobelda |
|
Cool! Thanks @wrobelda :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Adds new kf5auth port. Depends on #17268
Which triplets are supported/not supported? Have you updated the CI baseline?
All official should be supported.
Does your PR follow the maintainer guide?
Yes