Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][gsoap] Update to 2.8.112 #16837

Merged
merged 6 commits into from
Mar 25, 2021

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

  • What does your PR fix? Fixes #
-- Downloading https://sourceforge.net/projects/gsoap2/files//gsoap-2.8/gsoap_2.8.111.zip/download... Failed. Status: 22;"HTTP response code said error"
CMake Warning at scripts/cmake/vcpkg_download_distfile.cmake:202 (message):
      
      Failed to download file.

The current archive gsoap_2.8.111.zip doesn't exist now. So update it to the latest version 2.8.112.

Note: No feature needs to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Mar 23, 2021
@NancyLi1013 NancyLi1013 changed the title [gsoap] Update to 2.8.112 [vcpkg baseline][gsoap] Update to 2.8.112 Mar 23, 2021
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Mar 23, 2021
@ras0219-msft
Copy link
Contributor

ras0219-msft commented Mar 23, 2021

gsoap does not offer stable public downloads (they remove old versions from sourceforge), therefore we cannot include it in our testing set.

Instead, we should skip it and simply print a message for users:

message(FATAL_ERROR "gsoap does not offer permanent public downloads of its sources; all versions except the latest are removed from sourceforge. Therefore, vcpkg cannot support this library directly in the central catalog. If you would like to use gsoap, you can use this port as a starting point (${CMAKE_CURRENT_LIST_DIR}) and update it to use a permanent commercial copy or the latest public download. Do not report issues with this library to the vcpkg GitHub.")

(and add it as skip to ci.baseline.txt for all triplets).

scripts/ci.baseline.txt Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor Author

@ras0219-msft Could you help review and merge this PR?

@ras0219-msft ras0219-msft merged commit 48b59da into microsoft:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants