-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg baseline][gsoap] Update to 2.8.112 #16837
Merged
ras0219-msft
merged 6 commits into
microsoft:master
from
NancyLi1013:dev/NancyLi/update-gsoap-2
Mar 25, 2021
Merged
[vcpkg baseline][gsoap] Update to 2.8.112 #16837
ras0219-msft
merged 6 commits into
microsoft:master
from
NancyLi1013:dev/NancyLi/update-gsoap-2
Mar 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
added
category:port-bug
The issue is with a library, which is something the port should already support
info:internal
This PR or Issue was filed by the vcpkg team.
category:port-update
The issue is with a library, which is requesting update new revision
labels
Mar 23, 2021
This was referenced Mar 23, 2021
NancyLi1013
changed the title
[gsoap] Update to 2.8.112
[vcpkg baseline][gsoap] Update to 2.8.112
Mar 23, 2021
PhoebeHui
approved these changes
Mar 23, 2021
Instead, we should skip it and simply print a message for users: message(FATAL_ERROR "gsoap does not offer permanent public downloads of its sources; all versions except the latest are removed from sourceforge. Therefore, vcpkg cannot support this library directly in the central catalog. If you would like to use gsoap, you can use this port as a starting point (${CMAKE_CURRENT_LIST_DIR}) and update it to use a permanent commercial copy or the latest public download. Do not report issues with this library to the vcpkg GitHub.") (and add it as |
JackBoosY
suggested changes
Mar 24, 2021
JackBoosY
approved these changes
Mar 25, 2021
@ras0219-msft Could you help review and merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
category:port-update
The issue is with a library, which is requesting update new revision
info:internal
This PR or Issue was filed by the vcpkg team.
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
The current archive gsoap_2.8.111.zip doesn't exist now. So update it to the latest version 2.8.112.
Note: No feature needs to test.