-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pthreadpool] update sources and support find_package #17196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update to latest source code
This was referenced Apr 10, 2021
* use WindowStore in platform check
JackBoosY
suggested changes
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the changes is unofficial, please set the target name to unofficial-${TARGET}
.
OK. with ebf60e3, the export should be like the following.
user@host$ tree ./packages/pthreadpool_x64-osx/
./packages/pthreadpool_x64-osx/
├── BUILD_INFO
├── CONTROL
├── debug
│ └── lib
│ └── libpthreadpool.a
├── include
│ └── pthreadpool.h
├── lib
│ └── libpthreadpool.a
└── share
├── pthreadpool
│ ├── copyright
│ └── vcpkg_abi_info.txt
└── unofficial-pthreadpool
├── unofficial-pthreadpool-config-debug.cmake
├── unofficial-pthreadpool-config-release.cmake
└── unofficial-pthreadpool-config.cmake
7 directories, 10 files |
JackBoosY
approved these changes
Apr 15, 2021
Awesome, thanks @luncliff :) |
luncliff
commented
May 2, 2021
Yeah. I will make it tomorrow.
…On Sun, May 2, 2021, 10:11 PM Jack·Boos·Yu ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ports/pthreadpool/vcpkg.json
<#17196 (comment)>:
> "dependencies": [
"fxdiv",
{
"name": "pthreads",
- "platform": "uwp"
+ "platform": "windows & uwp"
Can you please make a new PR to fix that?
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17196 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLSYEZD7IV6SFW4S2ZCVI3TLVFRTANCNFSM42WNZAWA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
arm64-osx
. Support for macos_arm64: added config for macos_arm64 Maratyszcza/pthreadpool#14xnnpack
[xnnpack] create a new port #17064 needs support to findpthreads
andpthreadpool
artifacts easily.Support find_package
Export 2 targets.
pthreadpool_interface
(INTERFACE) andpthreadpool
(IMPORTED)Related Works
pthreadpool
was added)pthreads
supports ARM/UWP)Which triplets are supported/not supported? Have you updated the CI baseline?
windows & uwp
triplets should be availablearm64-osx
Does your PR follow the maintainer guide?
Yes. Wish the port works well.