Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pthreadpool] update sources and support find_package #17196

Merged
merged 4 commits into from
Apr 30, 2021
Merged

[pthreadpool] update sources and support find_package #17196

merged 4 commits into from
Apr 30, 2021

Conversation

luncliff
Copy link
Contributor

@luncliff luncliff commented Apr 10, 2021

What does your PR fix?

Support find_package

Export 2 targets. pthreadpool_interface(INTERFACE) and pthreadpool(IMPORTED)

    find_package(pthreadpool CONFIG REQUIRED)
    target_link_libraries(main PRIVATE pthreadpool pthreadpool_interface)

Related Works

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

Yes. Wish the port works well.

@luncliff luncliff marked this pull request as draft April 10, 2021 11:52
* use WindowStore in platform check
@luncliff luncliff marked this pull request as ready for review April 10, 2021 13:59
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the changes is unofficial, please set the target name to unofficial-${TARGET}.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist requires:author-response labels Apr 12, 2021
@luncliff
Copy link
Contributor Author

luncliff commented Apr 14, 2021

OK. with ebf60e3, the export should be like the following.

    find_package(unofficial-pthreadpool CONFIG REQUIRED)
    target_link_libraries(main PRIVATE unofficial::pthreadpool unofficial::pthreadpool_interface)
user@host$ tree ./packages/pthreadpool_x64-osx/
./packages/pthreadpool_x64-osx/
├── BUILD_INFO
├── CONTROL
├── debug
│   └── lib
│       └── libpthreadpool.a
├── include
│   └── pthreadpool.h
├── lib
│   └── libpthreadpool.a
└── share
    ├── pthreadpool
    │   ├── copyright
    │   └── vcpkg_abi_info.txt
    └── unofficial-pthreadpool
        ├── unofficial-pthreadpool-config-debug.cmake
        ├── unofficial-pthreadpool-config-release.cmake
        └── unofficial-pthreadpool-config.cmake

7 directories, 10 files

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Apr 15, 2021
@strega-nil-ms strega-nil-ms merged commit 6d29d41 into microsoft:master Apr 30, 2021
@strega-nil-ms
Copy link
Contributor

Awesome, thanks @luncliff :)

@luncliff luncliff deleted the port/pthreadpool branch April 30, 2021 21:58
@luncliff
Copy link
Contributor Author

luncliff commented May 2, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants