[cudnn] Fix port: install find module, add usage #17644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
reviewed
May 3, 2021
| @@ -70,3 +70,6 @@ elseif(VCPKG_TARGET_IS_WINDOWS) | |||
| else() | |||
| message(FATAL_ERROR "Please install CUDNN using your system package manager (the same way you installed CUDA). For example: apt install libcudnn8-dev.") | |||
| endif() | |||
|
|
|||
| file(INSTALL "${CURRENT_PORT_DIR}/FindCUDNN.cmake" DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT}) | |||
There was a problem hiding this comment.
I think we're supposed to install Xxx-config.cmake or XxxConfig rather than FindXxx? (Hoping a better cmake expert than I can point to policy/rationale but I've heard this before)
There was a problem hiding this comment.
well, at the beginning modules were preferred for non-cmake-built projects, hoping that upstream (in the project or in cmake itself) they could find a final home after some development here
imho, this is still the best approach (and still applied in many other ports, see ffmpeg for example)
There was a problem hiding this comment.
I see. In that case pay no attention to the Billy behind the curtain… 😂
JackBoosY
added
the
category:port-feature
NancyLi1013
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
#17331 removed the installation of
FindCUDNN.cmake, which breaks the port for downstream projects that havefind_dependencycalls that might require aFindCUDNNmodule. cc @BillyONealAdd back the installation of the module in addition to a
usage.Which triplets are supported/not supported? Have you updated the CI baseline?
No change
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes