Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minizip-ng] made cmake installs relative #17685

Merged
merged 4 commits into from
May 18, 2021
Merged

[minizip-ng] made cmake installs relative #17685

merged 4 commits into from
May 18, 2021

Conversation

prateek9623
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    After installation minizip cmake installs had some absolute paths which were making them unusable, this PR makes them relative

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

JackBoosY
JackBoosY suggested changes May 6, 2021
View reviewed changes
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-make patch made_cmake_install_relative.patch.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels May 6, 2021
@prateek9623
Copy link
Contributor Author

Please re-make patch made_cmake_install_relative.patch.

i tried making, but it was still failing locally

@JackBoosY
Copy link
Contributor

I'll handle this.

@JackBoosY
Copy link
Contributor

@prateek9623 I can be sure that the all relevant codes in patch CMakeLists-targets.patch almost do not exist, please delete buildtrees folder and remake this patch.

@prateek9623 prateek9623 force-pushed the minizip-ng-cmake-relative branch from 4c85ca1 to 65cc0d1 Compare May 7, 2021 09:12
@prateek9623
Copy link
Contributor Author

I found the issue, it was not with the patch I created, it was just a conflict between patches, as both patches change the same line in code. So, to fix that I need to modify old patch also

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 8, 2021
@prateek9623
Copy link
Contributor Author

this patch is not required if minizip-ng port is updated to 3.0.2

@prateek9623
Copy link
Contributor Author

@JackBoosY Hey, i have updated minizip-ng version, can you re-review it, thanks

@prateek9623 prateek9623 force-pushed the minizip-ng-cmake-relative branch from 662e101 to 34e01b2 Compare May 10, 2021 12:37
@JackBoosY JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label May 11, 2021
JackBoosY
JackBoosY suggested changes May 11, 2021
View reviewed changes
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run command ./vcpkg format-manifest --all then commit changes.

versions/m-/minizip-ng.json Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 11, 2021
@dan-shaw dan-shaw merged commit f68f30c into microsoft:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prateek9623 @JackBoosY @dan-shaw