Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cfitsio] Fix pc files #17696

Merged
merged 8 commits into from
May 21, 2021
Merged

[cfitsio] Fix pc files #17696

merged 8 commits into from
May 21, 2021

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented May 6, 2021 •
edited
Loading

  • What does your PR fix?

    • Fixes missing version, -l flags and dependencies in pc files.
    • Add 'd' suffix to the debug library.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    unchanged, CI baseline contains:

    cfitsio:arm-uwp=fail
cfitsio:x64-uwp=fail

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

Tested usage with pkg-config in WIP gdal branch for x64-linux.

@dg0yt
Copy link
Contributor Author

dg0yt commented May 6, 2021

PS: I have no idea if the Windows-only pthreads feature would need a "Requires" item in the pc file, too. But at least nobody missed it so far.

@dg0yt dg0yt mentioned this pull request May 6, 2021
Closed
@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels May 6, 2021
PhoebeHui
PhoebeHui requested changes May 6, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg0yt, thanks for the PR!

ports/cfitsio/portfile.cmake Outdated Show resolved Hide resolved
@dg0yt dg0yt changed the title [cfitsio] Fix pc files, add CMAKE_DEBUG_SUFFIX [cfitsio] Fix pc files May 6, 2021
PhoebeHui
PhoebeHui approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your updates!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 7, 2021
@dg0yt dg0yt marked this pull request as draft May 8, 2021 22:28
@dg0yt dg0yt marked this pull request as ready for review May 9, 2021 05:02
@dg0yt
Copy link
Contributor Author

dg0yt commented May 9, 2021

I rechecked this PR for mingw and feature configuration, but I don't want to modify this PR. Everything left as reviewed. Thanks.

@dg0yt
Copy link
Contributor Author

dg0yt commented May 16, 2021 •
edited
Loading

I moved the dependencies to Requires.private instead of Requires. This is for linking statically.

@dan-shaw dan-shaw merged commit 8e820ff into microsoft:master May 21, 2021
@dg0yt dg0yt deleted the cfitsio branch May 27, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dg0yt @PhoebeHui @dan-shaw