Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libb2] fix build #17914

Merged
merged 2 commits into from
May 21, 2021
Merged

[libb2] fix build #17914

merged 2 commits into from
May 21, 2021

Conversation

autoantwort
Copy link
Contributor

@autoantwort autoantwort commented May 13, 2021

Same as #17912 but with suggestion from @dg0yt here

Fixes #17894

@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label May 14, 2021
ports/libb2/vcpkg.json Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 18, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your fixing @autoantwort.

Copy link
Contributor

@ras0219 ras0219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-shaw dan-shaw merged commit 9b5cbe4 into microsoft:master May 21, 2021
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request May 21, 2021
@autoantwort autoantwort deleted the fix-bb2 branch September 1, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libb2] generates arm64 binaries for triplet x64-osx
5 participants