Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[librdkafka] Upgrade up to 1.7 #17937

Merged
merged 19 commits into from
May 18, 2021
Merged

Conversation

alexander-smyslov
Copy link
Contributor

[librdkafka] Upgrade up to 1.7

  • What does your PR fix?

Upgrade up to 1.7

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    <all / linux, windows, ...>, <Yes/No>

  • Does your PR follow the maintainer guide?

yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 15, 2021
Copy link
Member

@JonLiu1993 JonLiu1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-smyslov ,Pleease add FEATURES below the function like:
"vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
FEATURES
lz4 ENABLE_LZ4_EXT
ssl WITH_SSL
zlib WITH_ZLIB
zstd WITH_ZSTD
snappy WITH_SNAPPY
)"

@alexander-smyslov
Copy link
Contributor Author

Done

@alexander-smyslov
Copy link
Contributor Author

@alexander-smyslov ,Pleease add FEATURES below the function like:
"vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
FEATURES
lz4 ENABLE_LZ4_EXT
ssl WITH_SSL
zlib WITH_ZLIB
zstd WITH_ZSTD
snappy WITH_SNAPPY
)"

done

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 18, 2021
@dan-shaw dan-shaw merged commit b8d9229 into microsoft:master May 18, 2021
@alexander-smyslov alexander-smyslov deleted the librdkafka17 branch April 26, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants