Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[getopt-win32] fix static builds #17942

Merged
merged 15 commits into from
May 21, 2021
Merged

[getopt-win32] fix static builds #17942

merged 15 commits into from
May 21, 2021

Conversation

Neumann-A
Copy link
Contributor

No description provided.

@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 15, 2021
@JackBoosY
Copy link
Contributor 

Building package getopt-win32[core]:x64-windows-static...
-- Note: getopt-win32 only supports dynamic library linkage. Building dynamic library.
CMake Error at scripts/cmake/vcpkg_check_linkage.cmake:47 (message):
  Refusing to build unexpected dynamic library against the static CRT.  If
  this is desired, please configure your triplet to directly request this
  configuration.
Call Stack (most recent call first):
  ports/getopt-win32/portfile.cmake:5 (vcpkg_check_linkage)
  scripts/ports.cmake:142 (include)

JackBoosY
JackBoosY suggested changes May 18, 2021
View reviewed changes
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish ConfigurationType and RuntimeLibrary can be set as a option for vcpkg_install_msbuild or vcpkg_build_msbuild.

ports/getopt-win32/portfile.cmake Outdated Show resolved Hide resolved
Neumann-A and others added 2 commits May 18, 2021 08:39
@Neumann-A @JackBoosY
Update ports/getopt-win32/portfile.cmake
a67e321 
Apply CR changes

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
@Neumann-A
version stuff
e8aaff5
@JackBoosY
Copy link
Contributor

Depends on #17983.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label May 18, 2021
@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label May 20, 2021
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label May 20, 2021
@Neumann-A
Copy link
Contributor Author

@JackBoosY Why did you mark this as requires discussion?

@JackBoosY
Copy link
Contributor

I hope my colleague will do further review.

@dan-shaw dan-shaw merged commit 71f5a6f into microsoft:master May 21, 2021
@Neumann-A Neumann-A deleted the getopt_win32 branch May 21, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neumann-A @JackBoosY @dan-shaw