Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libtcod] Update to 1.18.0 #17946

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

HexDecimal
Copy link
Contributor

@HexDecimal HexDecimal commented May 15, 2021

  • What does your PR fix?

    Updates the libtcod port to the latest release.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All, No updates necessary.

  • Does your PR follow the maintainer guide?

    Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

@HexDecimal HexDecimal marked this pull request as draft May 15, 2021 03:36
@HexDecimal
Copy link
Contributor Author

HexDecimal commented May 15, 2021

I have a class TCODList that I've partially deprecated but is still used internally in some places. I think its use is being interpreted as an error instead of a warning in the UWP builds. It's something I can fix upstream.

@JonLiu1993 JonLiu1993 self-assigned this May 15, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 15, 2021
@HexDecimal HexDecimal marked this pull request as ready for review May 15, 2021 20:01
@HexDecimal HexDecimal marked this pull request as draft May 15, 2021 21:38
@HexDecimal HexDecimal changed the title [libtcod] Update to 1.17.0 [libtcod] Update to 1.18.0 May 16, 2021
@HexDecimal HexDecimal marked this pull request as ready for review May 16, 2021 04:05
@HexDecimal
Copy link
Contributor Author

I dealt with a few surprises. The port is now on 1.18.0: https://github.com/libtcod/libtcod/commits/1.18.0

This PR is ready for review.

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 18, 2021
@dan-shaw dan-shaw merged commit bef7849 into microsoft:master May 18, 2021
@HexDecimal HexDecimal deleted the update-libtcod branch November 12, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants