-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] [Android]Compile armv6 with arm mode #17962
Conversation
@dan-shaw, could you help further review? |
I change this setting because when I compile and run with default if(ANDROID_ABI MATCHES "armeabi")
if(ANDROID_ARM_MODE STREQUAL thumb)
list(APPEND ANDROID_COMPILER_FLAGS
-mthumb)
elseif(ANDROID_ARM_MODE STREQUAL arm)
list(APPEND ANDROID_COMPILER_FLAGS
-marm)
else() The default is if(NOT ANDROID_ARM_MODE)
set(ANDROID_ARM_MODE thumb)
endif() |
I will close this PR, because arm mode is good for our project, maybe for other project it not good: I will not delete this PR, because to let other people know about this for their android ndk armeabi project. |
I was thinking to re-open this PR When everything is compile with arm mode it don't happen. |
@strega-nil-ms, could you help further review? |
Thanks @talregev :) |
Compile armv6 with arm mode