Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draco] Fix build failure on gcc 11 #18001

Merged
merged 2 commits into from
May 21, 2021
Merged

Conversation

JackBoosY
Copy link
Contributor

Fix build failure:

[snip]
In file included from hash_utils.cc:15:
draco/core/hash_utils.h:27:1: error: 'size_t' does not name a type
   27 | size_t HashCombine(T1 a, T2 b) {
      | ^~~~~~
draco/core/hash_utils.h:21:1: note: 'size_t' is defined in header '<cstddef>'; did you forget to '#include <cstddef>'?
   20 | #include <functional>
  +++ |+#include <cstddef>
   21 | 
draco/core/hash_utils.h:34:1: error: 'size_t' does not name a type
   34 | size_t HashCombine(T a, size_t hash) {
      | ^~~~~~
draco/core/hash_utils.h:34:1: note: 'size_t' is defined in header '<cstddef>'; did you forget to '#include <cstddef>'?
draco/core/hash_utils.h:44:43: error: 'size_t' has not been declared
   44 | uint64_t FingerprintString(const char *s, size_t len);
      |                                           ^~~~~~
draco/core/hash_utils.h:49:3: error: 'size_t' does not name a type
   49 |   size_t operator()(const T &a) const {
      |   ^~~~~~
draco/core/hash_utils.h:49:3: note: 'size_t' is defined in header '<cstddef>'; did you forget to '#include <cstddef>'?
draco/core/hash_utils.h:58:3: error: 'size_t' does not name a type
   58 |   size_t ValueHash(const V &val) const {
      |   ^~~~~~
draco/core/hash_utils.h:58:3: note: 'size_t' is defined in header '<cstddef>'; did you forget to '#include <cstddef>'?
[snap]

Use the official commit google/draco#636.

Fixes #17963.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels May 19, 2021
@JackBoosY JackBoosY requested a review from NancyLi1013 May 19, 2021 08:27
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label May 20, 2021
@dan-shaw dan-shaw merged commit 6cec5c0 into microsoft:master May 21, 2021
@JackBoosY JackBoosY deleted the dev/jack/17963 branch May 21, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[draco] build failure x64-linux with gcc-11 libstdc++-11
3 participants