-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cudnn] Add library path #18005
Merged
ras0219-msft
merged 4 commits into
microsoft:master
from
NancyLi1013:dev/NancyLi/fix-cudnn
May 24, 2021
Merged
[cudnn] Add library path #18005
ras0219-msft
merged 4 commits into
microsoft:master
from
NancyLi1013:dev/NancyLi/fix-cudnn
May 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
added
category:port-bug
The issue is with a library, which is something the port should already support
info:internal
This PR or Issue was filed by the vcpkg team.
labels
May 19, 2021
is it really necessary? I can find CUDNN even with current module 🤔 |
On my machine, it doesn't work without the additional path
As you can see, it can only find headers in |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
JackBoosY
approved these changes
May 20, 2021
This LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:internal
This PR or Issue was filed by the vcpkg team.
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes #17680
Update
endif
asendif()
in FindCUDNN.cmake.vcpkg/ports/cudnn/FindCUDNN.cmake
Line 39 in c99dc50
Install
vcpkg-cmake-wrapper.cmake
toshare/${PORT}
to enablecudnn
found.Additional fixes:
Currently,
cuddn
needs to download from official website manually. The libs in the latest version 8.2.0 are listed in cuda/lib/x64 folder. So I addcuda/lib/x64
to the library path to enable the library found.Related #17377
Note: No feature needs to test.