[scripts-audit] z_vcpkg_apply_patches, z_vcpkg_escape_regex_control_characters #18013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JackBoosY
added
category:vcpkg-bug
JackBoosY
previously requested changes
May 20, 2021
strega-nil-ms
changed the title
strega-nil-ms
added
category:scripts-audit
strega-nil-ms
dismissed
JackBoosY’s stale review
internal functions can use fatal_error
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 25, 2021
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 25, 2021
|
Closing for rollup (#18112) |
strega-nil-ms
pushed a commit
that referenced
this pull request
May 26, 2021
* [scripts-audit] vcpkg_acquire_msys (#17687) * [vcpkg.cmake] Change find_package function -> macro in order to shorten trace (#17997) switch from function to macro * [scripts-audit] z_vcpkg_apply_patches (#18013) * [scripts-audit] z_vcpkg_escape_regex_control_characters (#18013) * [scripts-audit] vcpkg_fail_port_install (#18054) Note that this change allows existing failures; it changes MATCHES to STREQUAL, meaning that vcpkg_fail_port_install(ON_ARCH "arm") now succeeds on arm64; this change in behavior is fine (IMO) since it strictly succeeds when it used to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a minor bug as well, where
GIT_CONFIG_NOSYSTEMis never reset.