Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libsodium] Fix mingw builds #18025

Merged
merged 2 commits into from
May 24, 2021
Merged

Conversation

past-due
Copy link
Contributor

Describe the pull request
Fix mingw builds by better matching the behavior of libsodium's autoconf build scripts.

@NancyLi1013 NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label May 21, 2021
ports/libsodium/vcpkg.json Outdated Show resolved Hide resolved
@past-due past-due force-pushed the libsodium_mingw_1 branch from 42e5550 to 6661fd0 Compare May 21, 2021 15:17
@past-due
Copy link
Contributor Author

past-due commented May 21, 2021

@NancyLi1013: Force-pushed the requested change. 👍

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 24, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your fixing. @past-due

@ras0219-msft ras0219-msft merged commit 8f8a4f8 into microsoft:master May 24, 2021
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants