Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] document vcpkg_fixup_pkgconfig merging behaviour #18091

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

mcmtroffaes
Copy link
Contributor

This also documents the fact that pkg-config is never to be called with the --static flag. Maybe something should be added to the maintainer guide as well (i.e. .pc files should always work without --static), but for now, this seems like a good pace to add it.

See discussion in #17748.

cc @Neumann-A

@PhoebeHui PhoebeHui added the category:documentation To resolve the issue, documentation will need to be updated label May 25, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mcmtroffaes for your PR!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 26, 2021
@strega-nil-ms
Copy link
Contributor

To be merged as part of the Friday Rollup :)

Thanks @mcmtroffaes :)

@mcmtroffaes
Copy link
Contributor Author

Great, and you're very welcome!

@ras0219-msft ras0219-msft merged commit bec883f into microsoft:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:documentation To resolve the issue, documentation will need to be updated info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants