-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VCPKG_MAKE_CONFIGURE_OPTIONS (that can be set in the triplet) #18132
Add VCPKG_MAKE_CONFIGURE_OPTIONS (that can be set in the triplet) #18132
Conversation
To append options to the configure command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see the same changes in ports/vcpkg_cmake/vcpkg_cmake_configure.cmake
This needs to get documentation here and/or in |
Co-Authored-By: ras0219 <533828+ras0219@users.noreply.github.com>
Co-Authored-By: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump vcpkg-cmake
version. See documentation.
Also please run command vcpkg x-add-version vcpkg-cmake
then commit the changes.
@JackBoosY Done. 👍 (I'm still getting used to some of those scripts being proper ports now. 😅) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs fixin'
The single failure in x86_windows appears to have nothing to do with this PR:
|
Thanks @past-due :) |
Permits appending / forwarding options to the configure command (in
vcpkg_configure_make
) from a triplet.This should enable resolving a number of outstanding issues with various community (and custom) triplets, and avoid having to hard-code those fixes in
vcpkg_configure_make.cmake
itself.Adds support for three new triplet variables:
VCPKG_MAKE_CONFIGURE_OPTIONS
VCPKG_MAKE_CONFIGURE_OPTIONS_RELEASE
VCPKG_MAKE_CONFIGURE_OPTIONS_DEBUG
Example:
Add to a triplet:
To skip libtool checks that may errantly fail in a number of configurations / triplets.
@ras0219-msft @Neumann-A