[openssl] Restore Blowfish cipher in OpenSSL #18148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
added
the
category:port-feature
NancyLi1013
changed the title
NancyLi1013
reviewed
May 27, 2021
|
Thank you for your prompt feedback @NancyLi1013 - I've bumped the version 🙂 |
You have updated a port, so you have to :) |
|
Please also run .\vcpkg x-add-version openssl to update version files and then submit the changes. |
|
Should be done now 🙂 Please let me know if you have any other feedback |
NancyLi1013
approved these changes
May 28, 2021
Let's wait for CI test result. Currently, there is nothing needs to be done on your sides. |
|
CI appears to be passing - could this be landed now? 🙂 |
Yes, this is ready for merge now. |
|
lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL port today excludes Blowfish cipher on *nix platforms. I couldn't find a particular reason for why that is in
git blameand this is still a useful cipher to have for some older systems. This PR removesno-bfflag to restore Blowfish cipher on *nix and bring consistency across supported platforms.What does your PR fix?
Fixes How do I configure OpenSSL package? #17183
Which triplets are supported/not supported? Have you updated the CI baseline?
Only changes *nix port. As far as I can tell, Windows already has this cipher enabled
Does your PR follow the maintainer guide?
I believe so
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes