Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libssh] disable gssapi #18169

Merged
merged 2 commits into from
Jun 9, 2021
Merged

[libssh] disable gssapi #18169

merged 2 commits into from
Jun 9, 2021

Conversation

mcmtroffaes
Copy link
Contributor

@mcmtroffaes mcmtroffaes commented May 28, 2021 •
edited
Loading

  • What does your PR fix?

    The .pc file of libssh does not add the appropriate linking flags for gssapi when it is found as a system library on linux or osx. This patch disables the feature so libssh can still be linked against on those platforms. Potential fix for Fixes [ffmpeg:x64-osx] build failure #18166.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    No changes.

  • Does your PR follow the maintainer guide?

    Yes, to the best of my knowledge.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

@mcmtroffaes mcmtroffaes mentioned this pull request May 28, 2021
Closed
@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 28, 2021
@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels May 31, 2021
@NancyLi1013
Copy link
Contributor

Thanks for your fixing @mcmtroffaes.

@strega-nil-ms
Copy link
Contributor

Thanks @mcmtroffaes !

@strega-nil-ms strega-nil-ms merged commit 421fabc into microsoft:master Jun 9, 2021
@mcmtroffaes mcmtroffaes deleted the feature/libssh-disable-gssapi branch June 10, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ffmpeg:x64-osx] build failure
4 participants
@mcmtroffaes @NancyLi1013 @strega-nil-ms @JackBoosY